Page MenuHomePhabricator
Create Task
Maniphest T163843

RC filters - 'no-effect' states displayed as not muted
Closed, ResolvedPublic1 Estimated Story Points
Actions

Description

Found when verifying T163522: [betalabs-regression] RC filters - UI changes in displaying conflict states and 'no-effect' filters - the no-effect filter selection is not muted.

Screen Shot 2017-04-24 at 1.37.46 PM.png (376×685 px, 53 KB)

Details

SubjectRepoBranchLines +/-
RC Filters: Fix subset registrationsmediawiki/extensions/ORESmaster+10 -10
Customize query in gerrit

Related Objects

Event Timeline

Etonkovidova created this task.Apr 25 2017, 9:42 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptApr 25 2017, 9:42 PM
Etonkovidova updated the task description. (Show Details)Apr 25 2017, 9:43 PM
Etonkovidova mentioned this in T163522: [betalabs-regression] RC filters - UI changes in displaying conflict states and 'no-effect' filters .Apr 25 2017, 9:45 PM
Catrope moved this task from Untriaged to Ready for Pickup on the Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017) board.Apr 29 2017, 1:57 AM
Catrope set the point value for this task to 1.
SBisson subscribed.May 1 2017, 2:18 PM

I'm not sure what's wrong in the screenshot. Those 3 filters DO have an effect since they filter out everything that isn't scored with ORES damaging.

• jmatazzoni added a subscriber: Mooeypoo.May 1 2017, 3:05 PM
• jmatazzoni subscribed.

'Likely' and "Very likely" have no effect because they are subsets of "May." So they're already included. This used to work...

SBisson claimed this task.May 1 2017, 7:18 PM
SBisson moved this task from Ready for Pickup to In Development on the Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017) board.
gerritbot subscribed.May 1 2017, 7:19 PM

Change 351183 had a related patch set uploaded (by Sbisson; owner: Sbisson):
[mediawiki/extensions/ORES@master] RC Filters: Fix subset registrations

https://gerrit.wikimedia.org/r/351183

gerritbot added a project: Patch-For-Review.May 1 2017, 7:19 PM
SBisson moved this task from In Development to Needs Review on the Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017) board.May 1 2017, 7:20 PM
gerritbot added a comment.May 1 2017, 7:42 PM

Change 351183 merged by jenkins-bot:
[mediawiki/extensions/ORES@master] RC Filters: Fix subset registrations

https://gerrit.wikimedia.org/r/351183

SBisson moved this task from Needs Review to Product Review on the Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017) board.May 1 2017, 7:50 PM
SBisson moved this task from Product Review to QA Review on the Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017) board.
ReleaseTaggerBot added a project: MW-1.30-release-notes (WMF-deploy-2017-05-09_(1.30.0-wmf.1)).May 1 2017, 8:00 PM
Etonkovidova added a comment.EditedMay 1 2017, 10:51 PM

Checked in betalabs - the same selection filters as in the issue screenshot indicates that some of the selected filters are subsets of already selected (and the filters are in one group), and therefore, are muted visually:

Screen Shot 2017-05-01 at 3.48.26 PM.png (468×753 px, 109 KB)

QA Recommendation: Resolve

Etonkovidova moved this task from QA Review to Product Review on the Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017) board.May 1 2017, 10:53 PM
• jmatazzoni closed this task as Resolved.May 3 2017, 4:44 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL