Page MenuHomePhabricator
Create Task
Maniphest T163868

Move already-encapsulated useful classes into SmashPig
Closed, ResolvedPublic2 Estimated Story Points
Actions

Assigned To
Ejegg
Authored By
Ejegg
Apr 26 2017, 2:14 AM
Tags
Referenced Files
None
Subscribers
Aklapper
Ejegg
gerritbot

Description

Things like CurrencyRates, NationalCurrencies, FinalStatus, maybe ResponseProcessingException, PaymentResult.

Details

SubjectRepoBranchLines +/-
Use ValidationError from SmashPigmediawiki/extensions/DonationInterfacemaster+14 -29
Use PaymentError from SmashPigmediawiki/extensions/DonationInterfacemaster+15 -29
Use ValidationAction constants from SmashPigmediawiki/extensions/DonationInterfacemaster+71 -44
Push PaymentResult down into SmashPigwikimedia/fundraising/SmashPigmaster+129 -0
Move PaymentError and ValidationError to SmashPigwikimedia/fundraising/SmashPigmaster+81 -1
Move FinalStatus enum to SmashPig, add ValidationActionwikimedia/fundraising/SmashPigmaster+45 -15
Use SmashPig version of Currency classesmediawiki/extensions/DonationInterfacemaster+9 -443
CurrencyRates template: add SmashPig namespacewikimedia/fundraising/crmmaster+1 -0
Move CurrencyRates into SmashPigwikimedia/fundraising/SmashPigmaster+220 -0
Move NationalCurrencies into SmashPigwikimedia/fundraising/SmashPigmaster+224 -0
Customize query in gerrit

Event Timeline

Ejegg created this task.Apr 26 2017, 2:14 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptApr 26 2017, 2:14 AM
gerritbot subscribed.Apr 26 2017, 2:22 AM

Change 317653 had a related patch set uploaded (by Ejegg):
[wikimedia/fundraising/SmashPig@master] Move FinalStatus enum to SmashPig, add ValidationAction

https://gerrit.wikimedia.org/r/317653

gerritbot added a project: Patch-For-Review.Apr 26 2017, 2:22 AM
• DStrine moved this task from Triage to Completed in Q4 2016-17 on the Fundraising-Backlog board.Apr 26 2017, 10:45 PM
• DStrine added a project: Fundraising Sprint Ivory Tower Defense Games.Apr 26 2017, 10:50 PM
gerritbot added a comment.May 4 2017, 8:43 PM

Change 333152 had a related patch set uploaded (by Ejegg; owner: Ejegg):
[wikimedia/fundraising/SmashPig@master] Push PaymentResult down into SmashPig

https://gerrit.wikimedia.org/r/333152

Ejegg moved this task from Backlog to Doing on the Fundraising Sprint Ivory Tower Defense Games board.May 4 2017, 8:43 PM
Ejegg claimed this task.May 4 2017, 10:11 PM
Ejegg set the point value for this task to 2.
gerritbot added a comment.May 4 2017, 10:15 PM

Change 352047 had a related patch set uploaded (by Ejegg; owner: Ejegg):
[wikimedia/fundraising/crm@master] CurrencyRates template: add SmashPig namespace

https://gerrit.wikimedia.org/r/352047

gerritbot added a comment.May 4 2017, 10:44 PM

Change 352053 had a related patch set uploaded (by Ejegg; owner: Ejegg):
[wikimedia/fundraising/SmashPig@master] Move NationalCurrencies into SmashPig

https://gerrit.wikimedia.org/r/352053

gerritbot added a comment.May 4 2017, 10:51 PM

Change 352054 had a related patch set uploaded (by Ejegg; owner: Ejegg):
[wikimedia/fundraising/SmashPig@master] Move CurrencyRates into SmashPig

https://gerrit.wikimedia.org/r/352054

• DStrine added a project: Fundraising Sprint Judgement Suspenders.May 10 2017, 10:56 PM
Ejegg moved this task from Backlog to Doing on the Fundraising Sprint Judgement Suspenders board.May 11 2017, 7:30 PM
• ggellerman added a project: Fundraising Sprint Kickstopper.May 24 2017, 10:38 PM
• ggellerman moved this task from Backlog to Doing on the Fundraising Sprint Kickstopper board.May 24 2017, 10:49 PM
gerritbot added a comment.Jun 20 2017, 3:02 PM

Change 352054 merged by jenkins-bot:
[wikimedia/fundraising/SmashPig@master] Move CurrencyRates into SmashPig

https://gerrit.wikimedia.org/r/352054

gerritbot added a comment.Jun 20 2017, 3:04 PM

Change 352053 merged by jenkins-bot:
[wikimedia/fundraising/SmashPig@master] Move NationalCurrencies into SmashPig

https://gerrit.wikimedia.org/r/352053

• DStrine added a project: Fundraising Sprint Loose Lego Carpeting.Jun 21 2017, 8:17 PM
Ejegg moved this task from Backlog to Review on the Fundraising Sprint Loose Lego Carpeting board.Jun 29 2017, 4:39 PM
• DStrine added a project: Fundraising Sprint Murphy's Lawyer.Jul 5 2017, 8:24 PM
• DStrine moved this task from Completed in Q4 2016-17 to Current Sprint and Completed in Q1 2017-18 on the Fundraising-Backlog board.Jul 6 2017, 4:43 PM
Ejegg moved this task from Backlog to Pending Deployment on the Fundraising Sprint Murphy's Lawyer board.Jul 6 2017, 7:56 PM
gerritbot added a comment.Jul 6 2017, 11:57 PM

Change 352047 merged by jenkins-bot:
[wikimedia/fundraising/crm@master] CurrencyRates template: add SmashPig namespace

https://gerrit.wikimedia.org/r/352047

• DStrine added a project: Fundraising Sprint Navel Warfare.Jul 19 2017, 8:25 PM
Ejegg moved this task from Backlog to Pending Deployment on the Fundraising Sprint Navel Warfare board.Jul 21 2017, 4:26 PM
Ejegg moved this task from Pending Deployment to Review on the Fundraising Sprint Navel Warfare board.Jul 25 2017, 9:18 PM
gerritbot added a comment.Jul 28 2017, 2:45 PM

Change 363744 had a related patch set uploaded (by Ejegg; owner: Ejegg):
[mediawiki/extensions/DonationInterface@master] Use SmashPig version of Currency classes

https://gerrit.wikimedia.org/r/363744

• DStrine added a project: Fundraising Sprint Outie Inverter.Aug 2 2017, 8:20 PM
Ejegg moved this task from Backlog to Review on the Fundraising Sprint Outie Inverter board.Aug 2 2017, 8:40 PM
• DStrine added a project: Fundraising Sprint Prank Seatbelt.Aug 16 2017, 8:30 PM
Ejegg moved this task from Backlog to Review on the Fundraising Sprint Prank Seatbelt board.Aug 17 2017, 7:49 PM
gerritbot added a comment.Aug 29 2017, 1:51 PM

Change 363744 merged by jenkins-bot:
[mediawiki/extensions/DonationInterface@master] Use SmashPig version of Currency classes

https://gerrit.wikimedia.org/r/363744

ReleaseTaggerBot added a project: MW-1.30-release-notes (WMF-deploy-2017-08-29 (1.30.0-wmf.16)).Aug 29 2017, 2:00 PM
Ejegg moved this task from Review to Pending Deployment on the Fundraising Sprint Prank Seatbelt board.Aug 29 2017, 5:35 PM
Ejegg moved this task from Pending Deployment to Done on the Fundraising Sprint Prank Seatbelt board.Aug 29 2017, 8:58 PM
Ejegg moved this task from Done to Review on the Fundraising Sprint Prank Seatbelt board.Aug 29 2017, 9:06 PM

fr-tech: this one would probably be an easy review: https://gerrit.wikimedia.org/r/317653

• DStrine added a project: Fundraising Sprint Quill Pencil.Aug 30 2017, 8:22 PM
Ejegg moved this task from Backlog to Review on the Fundraising Sprint Quill Pencil board.Aug 31 2017, 3:26 PM
gerritbot added a comment.Sep 11 2017, 2:48 PM

Change 377279 had a related patch set uploaded (by Ejegg; owner: Ejegg):
[wikimedia/fundraising/SmashPig@master] Move PaymentError and ValidationError to SmashPig

https://gerrit.wikimedia.org/r/377279

gerritbot added a comment.Sep 11 2017, 4:37 PM

Change 317653 merged by jenkins-bot:
[wikimedia/fundraising/SmashPig@master] Move FinalStatus enum to SmashPig, add ValidationAction

https://gerrit.wikimedia.org/r/317653

gerritbot added a comment.Sep 11 2017, 7:18 PM

Change 377279 merged by jenkins-bot:
[wikimedia/fundraising/SmashPig@master] Move PaymentError and ValidationError to SmashPig

https://gerrit.wikimedia.org/r/377279

gerritbot added a comment.Sep 11 2017, 7:23 PM

Change 333152 merged by jenkins-bot:
[wikimedia/fundraising/SmashPig@master] Push PaymentResult down into SmashPig

https://gerrit.wikimedia.org/r/333152

Ejegg moved this task from Review to Pending Deployment on the Fundraising Sprint Quill Pencil board.Sep 12 2017, 3:44 PM
Ejegg closed this task as Resolved.Sep 12 2017, 4:34 PM
Ejegg triaged this task as Medium priority.
Ejegg moved this task from Pending Deployment to Done on the Fundraising Sprint Quill Pencil board.
gerritbot added a comment.Feb 1 2018, 10:17 PM

Change 407564 had a related patch set uploaded (by Ejegg; owner: Ejegg):
[mediawiki/extensions/DonationInterface@master] Use ValidationAction constants from SmashPig

https://gerrit.wikimedia.org/r/407564

gerritbot added a comment.Feb 1 2018, 10:22 PM

Change 407565 had a related patch set uploaded (by Ejegg; owner: Ejegg):
[mediawiki/extensions/DonationInterface@master] Use PaymentError from SmashPig

https://gerrit.wikimedia.org/r/407565

gerritbot added a comment.Feb 1 2018, 10:30 PM

Change 407566 had a related patch set uploaded (by Ejegg; owner: Ejegg):
[mediawiki/extensions/DonationInterface@master] Use ValidationError from SmashPig

https://gerrit.wikimedia.org/r/407566

gerritbot added a comment.Feb 7 2018, 8:29 PM

Change 407564 merged by jenkins-bot:
[mediawiki/extensions/DonationInterface@master] Use ValidationAction constants from SmashPig

https://gerrit.wikimedia.org/r/407564

gerritbot added a comment.Feb 7 2018, 8:46 PM

Change 407565 merged by jenkins-bot:
[mediawiki/extensions/DonationInterface@master] Use PaymentError from SmashPig

https://gerrit.wikimedia.org/r/407565

gerritbot added a comment.Feb 7 2018, 8:46 PM

Change 407566 merged by jenkins-bot:
[mediawiki/extensions/DonationInterface@master] Use ValidationError from SmashPig

https://gerrit.wikimedia.org/r/407566

ReleaseTaggerBot added a project: MW-1.31-release-notes (WMF-deploy-2018-02-13 (1.31.0-wmf.21)).Feb 7 2018, 9:00 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL