Page MenuHomePhabricator

test_datatypes is failing on test.wikidata.org because of a new datatype ('tabular-data')
Closed, ResolvedPublic

Description

https://travis-ci.org/wikimedia/pywikibot-core/jobs/225869298#L1760

____________________ WikibaseKnownTypesTests.test_datatypes ____________________

self = <tests.paraminfo_tests.WikibaseKnownTypesTests testMethod=test_datatypes>

    def test_datatypes(self):

        """Test that all encountered datatypes are known."""

        unsupported = set(['wikibase-property'])

        known = set(Property.types) | unsupported

        self._check_param_superset(

>           self.repo, 'wbformatvalue', 'datatype', known)

tests/paraminfo_tests.py:235: 

_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ 

tests/paraminfo_tests.py:53: in _check_param_superset

    self.assertGreaterEqual(set(expected), set(values))

E   AssertionError: {'monolingualtext', 'math', 'external-id', 'url', 'commonsMedia', 'time', 'quantity', 'geo-shape', 'wikibase-item', 'wikibase-property', 'globe-coordinate', 'string'} not greater than or equal to {'monolingualtext', 'math', 'time', 'url', 'commonsMedia', 'external-id', 'quantity', 'geo-shape', 'wikibase-item', 'wikibase-property', 'globe-coordinate', 'string', 'tabular-data'}

Event Timeline

Change 350403 had a related patch set uploaded (by Dalba):
[pywikibot/core@master] paraminfo_tests.py: Add 'tabular-data' to unsupported data types

https://gerrit.wikimedia.org/r/350403

Xqt claimed this task.
Xqt triaged this task as High priority.

Change 350403 merged by jenkins-bot:
[pywikibot/core@master] paraminfo_tests.py: Add 'tabular-data' to unsupported data types

https://gerrit.wikimedia.org/r/350403