Page MenuHomePhabricator
Create Task
Maniphest T163945

Visual Diff showing raw HTML after switching back from NWE
Closed, ResolvedPublic1 Estimated Story Points
Actions

Description

Steps to reproduce:

  1. Open VE
  2. Make some changes
  3. Go to visual diff section and see that everything looks fine
  4. Resume Editing

5.Switch to NWE

  1. Switch back to VE
  2. Open visual diff again

Observe that, on the right side of the dialog it is showing raw HTML which does not look like relevant to the change.

Screen Shot 2017-04-26 at 2.00.27 PM.png (920×470 px, 89 KB)

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
Update VE core submodule to master (3b8a164a3)mediawiki/extensions/VisualEditormaster+2 -1
VisualDiff: Don't describe internalItem changesVisualEditor/VisualEditormaster+6 -0
Customize query in gerrit

Related Objects

Event Timeline

Ryasmeen created this task.Apr 26 2017, 9:19 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptApr 26 2017, 9:19 PM
Esanders renamed this task from [Regression pre-wmf.22] Visual Diff showing raw HTML after switching back from NWE to Visual Diff showing raw HTML after switching back from NWE.Apr 27 2017, 1:03 PM
gerritbot subscribed.Apr 27 2017, 1:04 PM

Change 350550 had a related patch set uploaded (by Esanders; owner: Esanders):
[VisualEditor/VisualEditor@master] VisualDiff: Don't describe internalItem changes

https://gerrit.wikimedia.org/r/350550

gerritbot added a project: Patch-For-Review.Apr 27 2017, 1:04 PM
Jdforrester-WMF assigned this task to Esanders.Apr 27 2017, 2:24 PM
Jdforrester-WMF triaged this task as Medium priority.
Jdforrester-WMF added a project: VisualEditor-VisualDiffs.
Jdforrester-WMF set the point value for this task to 1.
Jdforrester-WMF moved this task from To Triage to TR6: Visual diffs on the VisualEditor board.
gerritbot added a comment.Apr 27 2017, 5:29 PM

Change 350550 merged by jenkins-bot:
[VisualEditor/VisualEditor@master] VisualDiff: Don't describe internalItem changes

https://gerrit.wikimedia.org/r/350550

gerritbot added a comment.Apr 28 2017, 3:43 PM

Change 350859 had a related patch set uploaded (by Jforrester; owner: Jforrester):
[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (a5deb2b73)

https://gerrit.wikimedia.org/r/350859

gerritbot added a comment.May 1 2017, 9:30 PM

Change 350859 merged by jenkins-bot:
[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (3b8a164a3)

https://gerrit.wikimedia.org/r/350859

Jdforrester-WMF closed this task as Resolved.May 1 2017, 9:31 PM
Jdforrester-WMF removed a project: Patch-For-Review.
Restricted Application added a project: User-Ryasmeen. · View Herald TranscriptMay 1 2017, 9:31 PM
Ryasmeen added a project: Verified.May 3 2017, 9:45 PM
Ryasmeen added a project: Verified-in-Phase0.May 3 2017, 9:48 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits