Visual updates to the Places feature - Search Bar overflow
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	• AMroczkowski
	Apr 28 2017, 2:30 PM

Description

Split from T163836

Finding 2

There are some issues with the search string and icon overflowing on some devices (one iPhone 7 and an iPhone 5c)

iPhone 5c 10.3.1	iPhone 7 10.3.1

Acceptance Criteria

For now, just shorten the prompt text to "Search"

Related Objects
Search...

		Status	Subtype	Assigned	Task
		Resolved		• AMroczkowski	T164076 Visual updates to the Places feature - Search Bar overflow
		Declined		• AMroczkowski	T164077 RFC Reimplement UISearchBar in Places?

Event Timeline

• AMroczkowski created this task.Apr 28 2017, 2:30 PM

• AMroczkowski updated the task description. (Show Details)

• AMroczkowski moved this task from Tasks from Product Backlog to Needs Engineering Sync on the iOS-app-v5.5.0-Snake-On-A-Magic-Towel board.

This appears to be an Apple bug, and there isn't a straightforward fix...

• AMroczkowski moved this task from Needs Engineering Sync to Blocked or Waiting on the iOS-app-v5.5.0-Snake-On-A-Magic-Towel board.Apr 28 2017, 3:08 PM

@AMroczkowski is there any autolayout logging when this happens?

@JoeWalsh I didn't notice any but it's trivial to reproduce. It happens on any UISearchBar

Semi-fixed by changing the text to "Search"

@AMroczkowski would it be possible to still have the icon and string left aligned?

@cmadeo Not unless we re-implement it as a text field. UISearchBar does not allow you to left-align text

@AMroczkowski if we populated the search field with the active search filter (eg. 'top read' or 'saved articles' ) would that allow us to keep the text and icon left aligned?

@cmadeo yes.

Apple wants UISearchBar has centered placeholder text, and left-aligned input text

If you'd rather just re-implement custom it's not very difficult, and we already have a custom search box elsewhere

@AMroczkowski if it isn't too much work or trouble (and won't cause input issues) then that would be preferable!

cmadeo moved this task from Needs Design Review to Blocked or Waiting on the iOS-app-v5.5.0-Snake-On-A-Magic-Towel board.May 1 2017, 6:28 PM

• JMinor triaged this task as Low priority.May 1 2017, 6:53 PM

• JMinor moved this task from Needs Triage to Bug Backlog on the Wikipedia-iOS-App-Backlog board.

• JMinor removed a project: Epic.

• JMinor updated the task description. (Show Details)May 9 2017, 6:44 PM

• AMroczkowski moved this task from Blocked or Waiting to Needs QA on the iOS-app-v5.5.0-Snake-On-A-Magic-Towel board.May 9 2017, 7:07 PM

Tested on an iPhone 7+ with iOS 10.3 and an iPhone 5s with iOS 10.2 on Beta App 5.5.0 (1134)

Fixed

Josve05a updated the task description. (Show Details)May 16 2017, 10:04 AM

• JMinor closed subtask T164077: RFC Reimplement UISearchBar in Places? as Declined.May 18 2017, 7:17 PM

• JMinor closed this task as Resolved.May 23 2017, 9:14 PM

• JMinor removed a subscriber: • Nizar.askri.

	F7760501: Screen Shot 2017-04-25 at 2.09.48 PM.png
	Apr 28 2017, 2:30 PM

	F7760502: Screen Shot 2017-04-25 at 2.10.50 PM.png
	Apr 28 2017, 2:30 PM

Visual updates to the Places feature - Search Bar overflowClosed, ResolvedPublicActions