Page MenuHomePhabricator

Tracking Task: Banners immediately returning after being dismissed.
Open, MediumPublic


There seems to have been a slight but noticeable uptick in users reporting that banners are not being properly suppressed after being dismissed, most recently by @Romaine .

The issue seems to not to be limited to any one particular banner and doesn't seem to be being caused by clearing session data/localstorage/cookies.

There have been a large number of new banners created with new code and shown to large populations of the community. There may be some sort of unknown issue being caused by either the banner itself or that there is a minor and difficult to replicate software issue that's being revealed from the large footprint CN is having on the community over the last few months.

This task is to track, monitor and try to explain what may be causing this increase in reports.

Event Timeline

Jseddon created this task.Apr 28 2017, 5:23 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptApr 28 2017, 5:23 PM

@Jseddon are you able to get more information from @Romaine

ggellerman triaged this task as Medium priority.May 2 2017, 9:14 PM
ggellerman moved this task from Triage to Q1 (July-Sept) 2020-2021 on the Fundraising-Backlog board.
K4-713 added a subscriber: K4-713.May 2 2017, 9:19 PM

When we investigate this further, please make sure we drill down into these two points:

  • When users experience this problem, are they logged in, or logged out?
  • Are the banners that appear post-close, part of the same campaign that was dismissed?

Is this being reported for fundraising banners, or community banners, or both?

MBeat33 added a comment.EditedMay 3 2017, 10:07 PM

The Spanish donor to whom we previously sent banner-hiding instructions provided the following feedback:

  • he's not logged in to a Wikipedia account
  • does not clear cookies when closing his browser
  • uses Firefox in non-private mode; visited the TY page for the cookie to insert
  • sees the banner on the main page of Catalan WP
  • screenshot:

Romaine added a comment.EditedJun 4 2017, 2:48 PM

Today the FDC banner is returning already 14 times after clicking the banner away each time. It is getting crazy.

Hi! I'm now able to reproduce this... (Seeing the issue with the FDC banner, now, too.) Looking into it now...

@AndyRussG How did you reproduce the error out of interest?

AndyRussG added a comment.EditedJun 4 2017, 11:29 PM

Hmmm it seems maybe I was mistaken--what looked like a banner closing and re-appearing was likely, in fact, two similar banners from different campaigns. Wasn't able to get a bona fide reproduction of the bug with confirmation that the banners were from the same campaign. When I stepped through the close and hide code on a production wiki (Meta) in my browser, everything seemed OK.

@Romaine and anyone else experiencing a problem with closed banners reappearing, could you please try the following: open a private browser window and go to the wiki where you've had this issue. If the issue happens when you're logged in, please log in. When you see a banner, close it, then open the browser's JS console, and paste in the following code:

'statusCode: ' + + ', banner: ' + + ', campaign: ' + + ', hideCookies: ' + JSON.stringify( $.map( document.cookie.split(';'), function( c ) { if ( c.includes( 'centralnotice_hide_' ) ) { return c.substr( 20 ).split( '=' )[ 0 ]; } } ) )

Press enter in the console, copy the output somewhere, and reload the page. If you see a banner again, close it. Whether or not you saw a banner, paste the above code into the console again, and copy the output somewhere. Repeat this process as many times as you wish. :) Finally, please paste here (or somewhere accessible) all the results received from the console. (There shouldn't be any private information in those results, but in any case, if you'd rather send them by e-mail or another means, that's also fine.) Thanks much!!!

@MBeat33 The mechanism for setting donate cookies is a bit different from that used to set close cookies, though the way the cookies actually hide banners once they're set is the same in both cases. So, the issue that that user experienced may or may not be related... Have there been many other reports of users still seeing banners after they donate? IIRC the TY page doesn't always set the cookies properly if the user is on a slow connection and/or they navigate away too quickly? If the user is able, perhaps they could also post the results of pasting the above code into the console? (However, in their case, they should not do so in a private window.) Also, could you please ask if the banner reappears after they click on the close button? Thanks!!! :D

@AndyRussG we see persistent-banner complaints pretty regularly, though in most cases it turns out to be something like setting their browser to automatically clear cookies upon close, or using multiple devices. Ones like that Spanish donor with detailed feedback are rare, and we haven't seen more recently. I will ask that donor to try the code in their JS console if they're still seeing it.