Notification to author gives wrong counts of sent and not sent mentions
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	PrimeHunter
	Apr 28 2017, 8:32 PM

Description

In https://en.wikipedia.org/w/index.php?title=User_talk:PrimeHunter2&diff=next&oldid=760171056 my PrimeHunter2 account saved the line:
:Pinging [[User:NoSuchUser]], [[User:PrimeHunter]], [[User:PrimeHunter3]]. ~~~~

The account has both "Failed mention" and "Successful mention" enabled at https://en.wikipedia.org/wiki/Special:Preferences#mw-prefsection-echo

It produced a notification to the author saying:

3 notifications about mentions you made on the ‪PrimeHunter2‬ talk page: 2 not sent, 1 sent.
Username does not exist: NoSuchUser
You mentioned: PrimeHunter3
You mentioned: PrimeHunter

Notification bug.png (365×565 px, 14 KB)

"2 not sent, 1 sent" should have said "1 not sent, 2 sent". The rest is correct. I own the accounts. PrimeHunter and PrimeHunter3 both received a notification.

The bug was discussed in January at https://en.wikipedia.org/wiki/Wikipedia:Village_pump_(technical)/Archive_152#Notifications

Details

Related Changes in Gerrit:

	Subject	Repo	Branch	Lines +/-
	Fix counting of bundled mention notifications	mediawiki/extensions/Echo	master	+2 -1

Customize query in gerrit

Event Timeline

PrimeHunter created this task.Apr 28 2017, 8:32 PM

Restricted Application added a project: TCB-Team (now WMDE-TechWish). · View Herald TranscriptApr 28 2017, 8:32 PM

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

• Lea_WMDE added a project: WMDE-TechWish.May 1 2017, 8:54 PM

Tobi_WMDE_SW moved this task from Proposed to Todo on the WMDE-TechWish board.May 2 2017, 2:42 PM

Change 351585 had a related patch set uploaded (by WMDE-Fisch; owner: WMDE-Fisch):
[mediawiki/extensions/Echo@master] Fix counting of bundled mention notifications

https://gerrit.wikimedia.org/r/351585

gerritbot added a project: Patch-For-Review.May 3 2017, 8:39 AM

WMDE-Fisch claimed this task.May 3 2017, 8:39 AM

WMDE-Fisch moved this task from Todo to Currently in sprint on the WMDE-TechWish board.

Change 351585 merged by jenkins-bot:
[mediawiki/extensions/Echo@master] Fix counting of bundled mention notifications

https://gerrit.wikimedia.org/r/351585

ReleaseTaggerBot added a project: MW-1.30-release-notes (WMF-deploy-2017-05-09_(1.30.0-wmf.1)).May 3 2017, 11:00 AM

WMDE-Fisch moved this task from Currently in sprint to Done on the WMDE-TechWish board.May 3 2017, 11:19 AM

WMDE-Fisch removed a project: Patch-For-Review.

Tobi_WMDE_SW closed this task as Resolved.May 30 2017, 10:21 AM

Tobi_WMDE_SW moved this task from Incoming to Mention Notifications on the TCB-Team (now WMDE-TechWish) board.Jun 6 2017, 10:16 AM

Tobi_WMDE_SW moved this task from Done to Demoed on the WMDE-TechWish board.Jun 6 2017, 3:13 PM

Tobi_WMDE_SW removed a project: WMDE-TechWish.Jun 7 2017, 11:59 AM

Notification to author gives wrong counts of sent and not sent mentionsClosed, ResolvedPublicActions

Description

Details

Event Timeline

Notification to author gives wrong counts of sent and not sent mentions
Closed, ResolvedPublic
Actions