Since https://gerrit.wikimedia.org/r/#/c/332398 you can't pass a $label to a fieldLayout so the hack in mediawiki.special.sandbox.js L:1582 does nothing.
Description
Description
Details
Details
| Subject | Repo | Branch | Lines +/- | |
|---|---|---|---|---|
| mw.special.apisandbox: Don't pass $label to OO.ui.FieldLayout | mediawiki/core | master | +5 -7 |
Related Objects
Related Objects
Event Timeline
Comment Actions
I don't know what "IE hack" you're talking about here. ApiSandbox is passing $label so it can set a 'click' event on it, FieldLayout's sometimes-forwarding isn't sufficient. There doesn't seem to be a documented way to get the generated label element, only to set it.
Comment Actions
Change 351336 had a related patch set uploaded (by Anomie; owner: Anomie):
[mediawiki/core@master] mw.special.apisandbox: Don't pass $label to OO.ui.FieldLayout
Comment Actions
I don't know what "IE hack" you're talking about here.
I must be going senile - I thought I read "InternetExplorer" in a comment, but apparently not.
Comment Actions
I didn't realize that this even could be done, much less that somebody would actually be doing it. Sorry.
I think that this entire thing is actually a bug in OOjs UI – you shouldn't need to override bits of FieldLayout to make it focus the field when the label is clicked. I filed T164506 for this. I think we can clean up a few gnarly things if we make this work consistently, actually.
Comment Actions
Change 351336 merged by jenkins-bot:
[mediawiki/core@master] mw.special.apisandbox: Don't pass $label to OO.ui.FieldLayout