Page MenuHomePhabricator
Create Task
Maniphest T164166

Visual diff does not show removal of space (joining words)
Closed, ResolvedPublic1 Estimated Story Points
Actions

Description

In this edit, I fixed a typo, changing Oude Mirdum to Oudemirdum. When I previewed the visual diff for this change, it showed me something like "Oude Mirdum mirdum", as if I had replaced the second word rather than joining the two words together.

visualdiff-space-wikitext.png (250×876 px, 23 KB)

visualdiff-space-visual.png (136×886 px, 20 KB)

Details

SubjectRepoBranchLines +/-
Update VE core submodule to master (fbeb0db2c)mediawiki/extensions/VisualEditormaster+2 -4
VisualDiff: Make annotation whitespace trimming configurableVisualEditor/VisualEditormaster+53 -35
Customize query in gerrit

Related Objects

Event Timeline

Catrope created this task.Apr 30 2017, 6:44 AM
Restricted Application added a project: VisualEditor. · View Herald TranscriptApr 30 2017, 6:44 AM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
Framawiki subscribed.Apr 30 2017, 10:59 AM
Esanders moved this task from To Triage to TR6: Visual diffs on the VisualEditor board.May 1 2017, 2:21 PM
Esanders subscribed.May 1 2017, 2:28 PM

Separating words with spaces also doesn't render any colours.

gerritbot subscribed.May 2 2017, 12:33 PM

Change 351305 had a related patch set uploaded (by Esanders; owner: Esanders):
[VisualEditor/VisualEditor@master] VisualDiff: Make annotation whitespace trimming configurable

https://gerrit.wikimedia.org/r/351305

gerritbot added a project: Patch-For-Review.May 2 2017, 12:33 PM
gerritbot added a comment.May 2 2017, 5:45 PM

Change 351305 merged by jenkins-bot:
[VisualEditor/VisualEditor@master] VisualDiff: Make annotation whitespace trimming configurable

https://gerrit.wikimedia.org/r/351305

gerritbot added a comment.May 8 2017, 9:47 PM

Change 352713 had a related patch set uploaded (by Jforrester; owner: Jforrester):
[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (fbeb0db2c)

https://gerrit.wikimedia.org/r/352713

gerritbot added a comment.May 10 2017, 3:36 PM

Change 352713 merged by jenkins-bot:
[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (fbeb0db2c)

https://gerrit.wikimedia.org/r/352713

Jdforrester-WMF closed this task as Resolved.May 10 2017, 3:40 PM
Jdforrester-WMF assigned this task to Esanders.
Jdforrester-WMF triaged this task as Medium priority.
Jdforrester-WMF removed a project: Patch-For-Review.
Jdforrester-WMF set the point value for this task to 1.
Restricted Application added a project: User-Ryasmeen. · View Herald TranscriptMay 10 2017, 3:40 PM
ReleaseTaggerBot added a project: MW-1.30-release-notes (WMF-deploy-2017-05-23_(1.30.0-wmf.2)).May 10 2017, 4:00 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL