Page MenuHomePhabricator

TagMultiselectWidget lacks focus indicator
Closed, ResolvedPublic

Description

The TagMultiselectWidget, as of v0.21.2, lacks keyboard focus indicator (primary color outline).

Event Timeline

Volker_E renamed this task from TagMultiselectWidget lacks keyboard focus indicator to TagMultiselectWidget lacks focus indicator.Apr 30 2017, 7:47 PM

Change 351121 had a related patch set uploaded (by VolkerE; owner: VolkerE):
[oojs/ui@master] MediaWiki theme: Provide focus indicator to TagMultiselectWidget

https://gerrit.wikimedia.org/r/351121

@Volker_E I think (correct me if I'm wrong) that this is only true for the inline-input version. In the outline-input, all focus on the widget is delivered to the input itself, which has a focus state.

Inside the widget, there are focus states for individual tags, which works best for the 'no input' state.

With the inline input, we pretend the entire tag area is the input (even though that is not true technically) so the input focus is taken out (among other things that was one of the reasons to take the $input piece of the InputWidget rather than the entire TextInputWidget)

If we add a general focus for the widget, we might end up with a state where outline-input has double focus border...?

So is this more a fix for the inline-input? If so, where should the focus appear? As a wrapper for the entire tag area?

@Mooeypoo I've already proposed a patch, which adds a -focus class. Don't think that we need to make a difference in setting the class between outlined and inlined widget. Naming is another thing, that would be the first -focus class, but we've got several -active ones. (Assigned the task first to you and then decided to try the shortcut on my own ;) )

Change 351121 merged by jenkins-bot:
[oojs/ui@master] MediaWiki theme: Provide focus indicator to TagMultiselectWidget

https://gerrit.wikimedia.org/r/351121

Volker_E claimed this task.
Volker_E triaged this task as Medium priority.
Volker_E moved this task from Reviewing to OOjs-UI-0.21.3 on the OOUI board.
Volker_E edited projects, added OOUI (OOjs-UI-0.21.3); removed OOUI.
Volker_E edited projects, added Accessibility; removed Patch-For-Review.
Volker_E edited subscribers, added: Mooeypoo; removed: gerritbot.