Page MenuHomePhabricator

Transclusion table cells: editing transclusion causes error about mergeable cells
Closed, ResolvedPublic1 Story Points

Description

TypeError: selection.isMergeable is not a function at VeUiMergeCellsContextItem.ve.ui.MergeCellsContextItem.setup (http://dev.wiki.local.wmftest.net:8080/w/extensions/VisualEditor/lib/ve/src/ui/contextitems/ve.ui.MergeCellsContextItem.js?82ffd:56:27) at VeUiDesktopContext.ve.ui.Context.setupMenuItems (http://dev.wiki.local.wmftest.net:8080/w/extensions/VisualEditor/lib/ve/src/ui/ve.ui.Context.js?b3717:160:14) at VeUiDesktopContext.ve.ui.LinearContext.afterContextChange (http://dev.wiki.local.wmftest.net:8080/w/extensions/VisualEditor/lib/ve/src/ui/contexts/ve.ui.LinearContext.js?4f225:118:10) at VeUiDesktopContext.ve.ui.DesktopContext.afterContextChange (http://dev.wiki.local.wmftest.net:8080/w/extensions/VisualEditor/lib/ve/src/ui/contexts/ve.ui.DesktopContext.js?07a30:74:58)

i.e. isMergeable = selection.isMergeable();

...and then it changes the context item to look like this:

Event Timeline

DLynch created this task.May 1 2017, 3:38 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMay 1 2017, 3:38 PM

Change 351157 had a related patch set uploaded (by DLynch; owner: DLynch):
[VisualEditor/VisualEditor@master] MergeCellsContextItem: Make sure we're on a TableSelection

https://gerrit.wikimedia.org/r/351157

Change 351157 merged by jenkins-bot:
[VisualEditor/VisualEditor@master] MergeCellsContextItem: Make sure we're on a TableSelection

https://gerrit.wikimedia.org/r/351157

Jdforrester-WMF closed this task as Resolved.May 1 2017, 5:54 PM
Jdforrester-WMF assigned this task to DLynch.
Jdforrester-WMF triaged this task as Normal priority.
Jdforrester-WMF edited projects, added VisualEditor-Tables; removed Patch-For-Review.
Jdforrester-WMF set the point value for this task to 1.
Jdforrester-WMF moved this task from To Triage to TR1: Releases on the VisualEditor board.
Restricted Application added a project: User-Ryasmeen. · View Herald TranscriptMay 1 2017, 5:54 PM

Change 350859 had a related patch set uploaded (by Jforrester; owner: Jforrester):
[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (3b8a164a3)

https://gerrit.wikimedia.org/r/350859

Change 350859 merged by jenkins-bot:
[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (3b8a164a3)

https://gerrit.wikimedia.org/r/350859