onMenuToggle exists in the parent class, but it's blindly overridden with duplication of some (but not all!) of the parent's logic, and it's bound again in the constructor. This means that it runs twice, and that the code for counting how many times the highlight button has been shown double-counts every instance of the menu opening.
Description
Description
Details
Details
Related Changes in Gerrit:
| Subject | Repo | Branch | Lines +/- | |
|---|---|---|---|---|
| RC Filters: don't bind onMenuToggle twice | mediawiki/core | master | +5 -4 |
Event Timeline
Comment Actions
Change 351322 had a related patch set uploaded (by Sbisson; owner: Sbisson):
[mediawiki/core@master] RC Filters: don't bind onMenuToggle twice
Comment Actions
Change 351322 merged by jenkins-bot:
[mediawiki/core@master] RC Filters: don't bind onMenuToggle twice
Comment Actions
Re-checked in betalabs - rcenhancedfilters-seen-highlight-button-counter value increases correctly according to users' input.
QA Recommendation: Resolve