Maniphest T164311

Consolidate dark mode
Closed, ResolvedPublic3 Estimated Story Points
Actions

Description

apps-android-wikipedia/www/js/transforms/addDarkModeStyles.js
apps-android-wikipedia/www/js/dark.js
apps-android-wikipedia/www/js/constant.js
apps-android-wikipedia/www/js/loader.js
MobileApp/styles/android/night.less
rename "night" terminology to dark
change transforms to use an extra class instead of an extra stylesheet. the current implementation like dynamically replaces the stylesheets or something

Details

	Subject	Repo	Branch	Lines +/-
	Hygiene: consolidate dark theming in wikimedia-page-library	mediawiki/extensions/MobileApp	master	+0 -58

Customize query in gerrit

Related Objects
Search...

		Status	Subtype	Assigned	Task
		Open		None	T163839 Phase one: consolidate the JavaScript transforms and associated CSS
		Resolved		• Niedzielski	T164311 Consolidate dark mode
		Resolved		Dbrant	T165415 Integrate dark mode on Android
		Resolved		Sharvaniharan	T172984 Consolidate light and dark mode color scheme on Android
		Resolved		Dbrant	T139187 Consolidate color resources and styles throughout the app.
		Resolved		cooltey	T173091 [BUG] Error text should use the Red75 color stipulated when in dark mode
		Resolved		Sharvaniharan	T173302 [BUG] Update card colors in dark mode to use Base14-Thermosphere Gray
		Resolved		• Mholloway	T170304 [Design debt] Make app bar colors consistent everywhere on the app
		Duplicate		Mhurd	T165416 Integrate dark mode on iOS

Event Timeline

• Niedzielski created this task.May 2 2017, 10:14 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMay 2 2017, 10:14 PM

• Niedzielski triaged this task as High priority.May 2 2017, 10:18 PM

• Niedzielski added a parent task: T163839: Phase one: consolidate the JavaScript transforms and associated CSS.

• Niedzielski updated the task description. (Show Details)

• Niedzielski moved this task from Open to Phase One on the wikimedia-page-library board.May 3 2017, 10:14 PM

Mhurd edited projects, added wikimedia-page-library-tshirt; removed wikimedia-page-library.May 11 2017, 9:31 PM

• Niedzielski updated the task description. (Show Details)May 15 2017, 10:05 PM

• Niedzielski created subtask T165415: Integrate dark mode on Android.

• Niedzielski created subtask T165416: Integrate dark mode on iOS.

• Niedzielski updated the task description. (Show Details)May 17 2017, 7:58 PM

• Niedzielski moved this task from Backlog to L on the wikimedia-page-library-tshirt board.

• Niedzielski set the point value for this task to 3.May 22 2017, 4:14 PM

• Niedzielski edited projects, added wikimedia-page-library; removed wikimedia-page-library-tshirt.Jun 12 2017, 7:57 PM

• Niedzielski moved this task from Phase One to Dark Mode on the wikimedia-page-library board.Jun 12 2017, 8:03 PM

• Niedzielski added a project: Wikipedia-Android-App-Backlog (Android-app-release-v2.7.20x-Dookie💩).Jul 12 2017, 6:56 PM

• Niedzielski moved this task from To Do to Code Review on the Wikipedia-Android-App-Backlog (Android-app-release-v2.7.20x-Dookie💩) board.Jul 13 2017, 10:07 PM

The iOS integration is complete, therefore the consolidation is complete.

Change 365055 merged by jenkins-bot:
[mediawiki/extensions/MobileApp@master] Hygiene: consolidate dark theming in wikimedia-page-library

https://gerrit.wikimedia.org/r/365055

ReleaseTaggerBot added a project: MW-1.30-release-notes (WMF-deploy-2017-08-01_(1.30.0-wmf.12)).Jul 26 2017, 1:01 AM

Dbrant closed subtask T165415: Integrate dark mode on Android as Resolved.Aug 24 2017, 5:53 PM