Page MenuHomePhabricator

Remove div overflow from Android
Closed, ResolvedPublic0.5 Estimated Story Points

Description

apps-android-wikipedia/www/js/transforms/setDivWidth.js

This doesn't appear to be doing anything any more.

Event Timeline

iOS since no implementation exists there yet

We removed it... details here:
https://phabricator.wikimedia.org/T160970

I think Android should probably remove it as well.

Niedzielski renamed this task from Consolidate div overflow to Remove div overflow from Android.May 3 2017, 9:06 PM
Niedzielski updated the task description. (Show Details)

I poked around a little more, and it seems on iOS it looks like we're *still* supplementing the CSS to make this work.

In our misc.less we have this...

.content_block {
    clear:both;
    overflow-x: auto;
    font-size: 16px;
}

...without which the page width explodes on pages like "enwiki > Counties of England".

It would be interesting to see if this is because of some of the mobile app extension CSS delta... probably isn't but would be nice to confirm.

Seeing that iOS is still doing these overflow bits it looks like we still have some consolidation to do :)

Niedzielski renamed this task from Remove div overflow from Android to Consolidate div overflow.May 4 2017, 10:49 PM

@Mhurd, thanks for the update! I've revised the title :]

Niedzielski renamed this task from Consolidate div overflow to Remove div overflow from Android.Jun 5 2017, 8:00 PM
Niedzielski updated the task description. (Show Details)
Niedzielski moved this task from Backlog to XS on the wikimedia-page-library-tshirt board.
Niedzielski set the point value for this task to 0.5.Jun 5 2017, 8:16 PM

Change 357246 had a related patch set uploaded (by Niedzielski; owner: Sniedzielski):
[apps/android/wikipedia@master] Hygiene: remove div overflow JavaScript transform

https://gerrit.wikimedia.org/r/357246

I posted the following in irc...

hey i just found a page which gets explode-y on iOS w/o that overflow css... enwiki > lagrangian point. may want to check it on android before removing that transform...

Screen Shot 2017-06-05 at 4.02.18 PM.png (1×862 px, 337 KB)

Also see: "Liste de sondages sur l'élection présidentielle française de 2017" in french wiki.

From: T161405

on iOS:

Screen Shot 2017-06-05 at 4.29.33 PM.png (1×862 px, 256 KB)

I think I found a fix which makes iOS no longer EXPLODE-Y when we remove the CSS in question. The same fix may work for Android. Will post fix and add another comment with link so you can check it out...

Here are the iOS fixes I mentioned which allowed the removal of the CSS overrides I mentioned in the comment above.

Change 357246 merged by jenkins-bot:
[apps/android/wikipedia@master] Hygiene: remove div overflow JavaScript transform

https://gerrit.wikimedia.org/r/357246