Page MenuHomePhabricator
Create Task
Maniphest T164350

[regression wmf.21] Unwatch icon not visible on Monobook
Closed, ResolvedPublic
Actions

Description

Unwatch icon is not visible on monobook. Place where it should be can be clicked and works but I can't see blue star indicating I watch particular topic.

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
Fix unwatch icon in monobookmediawiki/extensions/Flowmaster+4 -4
Customize query in gerrit

Related Objects

Event Timeline

Wargo created this task.May 3 2017, 9:33 AM
Restricted Application added a project: Collaboration-Team-Triage. · View Herald TranscriptMay 3 2017, 9:33 AM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
Trizek-WMF added subscribers: Etonkovidova, Trizek-WMF.May 3 2017, 9:41 AM

Got it.

Capture d’écran_2017-05-03_11-39-05.png (150×311 px, 18 KB)

Etonkovidova added a comment.May 3 2017, 4:56 PM

The issue is present in betalabs too.

Etonkovidova renamed this task from Unwatch icon not visible on Monobook to [regression wmf.21] Unwatch icon not visible on Monobook.May 3 2017, 5:00 PM
Etonkovidova edited projects, added Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017), Regression; removed Collaboration-Team-Triage.
Catrope subscribed.May 3 2017, 5:14 PM

This may be a regression from me messing with OOUI icon packs, will investigate.

Catrope added a comment.May 3 2017, 5:52 PM

I think this is older, and caused by the apex theme in OOUI not having icon variants. Workaround patch incoming.

gerritbot subscribed.May 3 2017, 7:54 PM

Change 351704 had a related patch set uploaded (by Catrope; owner: Catrope):
[mediawiki/extensions/Flow@master] Fix unwatch icon in monobook

https://gerrit.wikimedia.org/r/351704

gerritbot added a project: Patch-For-Review.May 3 2017, 7:54 PM
gerritbot added a comment.May 3 2017, 9:19 PM

Change 351704 merged by jenkins-bot:
[mediawiki/extensions/Flow@master] Fix unwatch icon in monobook

https://gerrit.wikimedia.org/r/351704

ReleaseTaggerBot added a project: MW-1.30-release-notes (WMF-deploy-2017-05-09_(1.30.0-wmf.1)).May 3 2017, 10:00 PM
Catrope moved this task from Untriaged to QA Review on the Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017) board.May 4 2017, 12:15 AM
Etonkovidova added a comment.EditedMay 4 2017, 6:25 PM

Checked in betalabs:

Screen Shot 2017-05-04 at 11.09.16 AM.png (388×1 px, 38 KB)

In FF 53, there is a strange issue with the star icon twinkles when a cursor hovers over it. The issue is very minor - filed as T164519: [minor] monobook: FF only - the star icon twinkles when hovered over

QA Recommendation: Resolve

Etonkovidova moved this task from QA Review to Product Review on the Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017) board.May 4 2017, 6:26 PM
Wargo added a project: Edit-Review-Improvements-Integrated-Filters.May 7 2017, 11:25 AM

The same reason is for collapsing checkbox in ERI filters?

Aklapper removed a project: Edit-Review-Improvements-Integrated-Filters.May 7 2017, 12:40 PM

My understanding is that this task is about Flow, not about Edit-Review-Improvements-Integrated-Filters :)

Catrope added a comment.May 8 2017, 6:22 PM
In T164350#3241330, @Wargo wrote:

The same reason is for collapsing checkbox in ERI filters?

I think you might be talking about T164550.

• jmatazzoni closed this task as Resolved.May 8 2017, 9:23 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits