Page MenuHomePhabricator
Create Task
Maniphest T164410

Mediaviewer controls disappear after returning from a fullscreen 3D object
Closed, ResolvedPublic
Actions

Description

Steps:

  1. Go an article with a 3D object (Tested on https://commons.wikimedia.beta.wmflabs.org/wiki/3d)
  2. Click on the 3D object
  3. Click on the fullscreen expand control
  4. Rotate/zoom the object a bit
  5. Exit fullscreen by clicking the reduce control

Expected Result:
The mediaviewer returns to window size and the controls remain onscreen.

Actual Result:
After a second or two the controls disappear and the user must click back to exit mediaviewer.

Details

SubjectRepoBranchLines +/-
Fix buttons fadeOut when coming back from fullscreenmediawiki/extensions/MultimediaViewermaster+22 -4
Customize query in gerrit

Event Timeline

ABorbaWMF created this task.May 3 2017, 6:18 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMay 3 2017, 6:18 PM
dr0ptp4kt triaged this task as High priority.May 31 2017, 4:54 PM
dr0ptp4kt added a project: Multimedia.
dr0ptp4kt moved this task from Untriaged to Next up on the Multimedia board.May 31 2017, 4:57 PM
matthiasmullie claimed this task.Jun 2 2017, 12:02 PM
matthiasmullie added a comment.Jun 7 2017, 2:55 PM

This did not just happen with 3D files, but also for other file types.
The fadeOut behavior depends on mouse movement, so I guess this just became more apparent with 3D files because they encourage more mouse movement to drag them around.

gerritbot subscribed.Jun 7 2017, 2:55 PM

Change 357625 had a related patch set uploaded (by Matthias Mullie; owner: Matthias Mullie):
[mediawiki/extensions/MultimediaViewer@master] Fix buttons fadeOut when coming back from fullscreen

https://gerrit.wikimedia.org/r/357625

gerritbot added a project: Patch-For-Review.Jun 7 2017, 2:55 PM
gerritbot added a comment.Jun 7 2017, 4:16 PM

Change 357625 merged by jenkins-bot:
[mediawiki/extensions/MultimediaViewer@master] Fix buttons fadeOut when coming back from fullscreen

https://gerrit.wikimedia.org/r/357625

ReleaseTaggerBot added a project: MW-1.30-release-notes (WMF-deploy-2017-06-13_(1.30.0-wmf.5)).Jun 7 2017, 5:00 PM
MarkTraceur moved this task from Next up to Needs code review on the Multimedia board.Jun 9 2017, 6:18 PM
matthiasmullie closed this task as Resolved.Jun 12 2017, 3:15 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL