Page MenuHomePhabricator
Create Task
Maniphest T164455

RevisionSlider should not assume that revision ids increase in time
Closed, ResolvedPublic
Actions

Description

Apparently RevisionSlider assumes in some parts of its logic that revision ids increase in time. That's not always the case and leads to strange behavior.

e.g. see https://www.mediawiki.org/w/index.php?title=Extension%3AExpandCss&type=revision&diff=50164&oldid=51766

Taken from feedback in: https://www.mediawiki.org/wiki/Topic:Tpejiph9fv818kil

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
Do not assume that revIds increase in timemediawiki/extensions/RevisionSlidermaster+66 -67
Customize query in gerrit

Related Objects

Event Timeline

WMDE-Fisch created this task.May 4 2017, 8:40 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMay 4 2017, 8:40 AM
IKhitron subscribed.May 4 2017, 11:05 PM
WMDE-Fisch claimed this task.May 5 2017, 9:40 AM
WMDE-Fisch moved this task from Proposed to Sprint ready on the WMDE-TechWish board.
WMDE-Fisch moved this task from Sprint ready to Todo on the WMDE-TechWish board.May 8 2017, 9:07 AM
WMDE-Fisch moved this task from Todo to Sprint ready on the WMDE-TechWish board.May 8 2017, 11:32 AM
• Lea_WMDE moved this task from Incoming to Doing on the Revision-Slider board.May 8 2017, 12:18 PM
gerritbot subscribed.May 9 2017, 11:45 AM

Change 352801 had a related patch set uploaded (by WMDE-Fisch; owner: WMDE-Fisch):
[mediawiki/extensions/RevisionSlider@master] Do not assume revIds increase in time

https://gerrit.wikimedia.org/r/352801

gerritbot added a project: Patch-For-Review.May 9 2017, 11:45 AM
WMDE-Fisch moved this task from Sprint ready to Currently in sprint on the WMDE-TechWish board.May 9 2017, 11:46 AM
WMDE-Fisch mentioned this in rERSL6833f44cf88c: Do not assume revIds increase in time.May 9 2017, 11:47 AM
WMDE-Fisch mentioned this in rERSLb96e0cd25be1: Do not assume revIds increase in time.May 9 2017, 11:53 AM
WMDE-Fisch mentioned this in rERSL017d3a7d6db3: DNM Do not assume revIds increase in time.May 9 2017, 12:09 PM
WMDE-Fisch mentioned this in rERSL6c497283809d: Do not assume that revIds increase in time.May 31 2017, 1:40 PM
WMDE-Fisch mentioned this in rERSLb0b09cfa553b: DNM Do not assume revIds increase in time.
Tobi_WMDE_SW mentioned this in rERSL23286211666f: Do not assume that revIds increase in time.Jun 1 2017, 3:46 PM
WMDE-Fisch mentioned this in rERSL0525f0bdb274: Do not assume that revIds increase in time.Jun 1 2017, 4:31 PM
Tobi_WMDE_SW moved this task from Incoming to Revision Slider on the TCB-Team (now WMDE-TechWish) board.Jun 6 2017, 10:11 AM
gerritbot added a comment.Jun 6 2017, 10:35 AM

Change 352801 merged by jenkins-bot:
[mediawiki/extensions/RevisionSlider@master] Do not assume that revIds increase in time

https://gerrit.wikimedia.org/r/352801

ReleaseTaggerBot added a project: MW-1.30-release-notes (WMF-deploy-2017-06-06_(1.30.0-wmf.4)).Jun 6 2017, 11:00 AM
Tobi_WMDE_SW closed this task as Resolved.Jun 6 2017, 1:15 PM
Tobi_WMDE_SW moved this task from Currently in sprint to Done on the WMDE-TechWish board.
Tobi_WMDE_SW moved this task from Done to Demoed on the WMDE-TechWish board.Jun 6 2017, 2:45 PM
Tobi_WMDE_SW removed a project: WMDE-TechWish.Jun 7 2017, 11:59 AM
thiemowmde removed a project: TCB-Team (now WMDE-TechWish).Jan 7 2022, 3:06 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits