Page MenuHomePhabricator
Create Task
Maniphest T164473

Fix MultimediaViewer qunit tests
Closed, ResolvedPublic
Actions

Description

See https://integration.wikimedia.org/ci/job/mwext-qunit-jessie/10341/consoleFull

Details

ProjectBranchLines +/-Subject
mediawiki/extensions/MultimediaViewermaster+6 -3Fix mmv.model.TaskQueue qunit tests
mediawiki/extensions/MultimediaViewermaster+9 -2Fix mmv.lightboxInterface qunit tests
mediawiki/extensions/MultimediaViewermaster+22 -0Fix mmv.logging.DurationLogger qunit tests
mediawiki/extensions/MultimediaViewermaster+79 -61Fix mmv.logging.PerformanceLogger qunit tests
mediawiki/extensions/MultimediaViewermaster+7 -1Fix mmv.logging.ActionLogger qunit tests
mediawiki/extensions/MultimediaViewermaster+12 -0Fix mmv.logging.ViewLogger qunit tests
mediawiki/extensions/MultimediaViewermaster+1 -1Fix mmv.model.TaskQueue qunit tests
mediawiki/extensions/MultimediaViewermaster+6 -1Fix mmw.ui.metadataPanel qunit tests
mediawiki/extensions/MultimediaViewermaster+168 -109Fix mmv qunit tests
mediawiki/extensions/MultimediaViewermaster+229 -122Fix mmv.bootstrap qunit tests
Customize query in gerrit

Related Objects
Search...

StatusSubtypeAssignedTask
 ResolvedKrinkleT127328 Optimise critical rendering path
 ResolvedKrinkleT124742 Upgrade to jQuery 3
 ResolvedmatthiasmullieT164473 Fix MultimediaViewer qunit tests

Event Timeline

matthiasmullie created this task.May 4 2017, 10:44 AM
Restricted Application added a subscriber: • Aklapper. · View Herald TranscriptMay 4 2017, 10:44 AM
matthiasmullie added a parent task: T124742: Upgrade to jQuery 3.May 5 2017, 12:36 PM

Tests are broken since https://gerrit.wikimedia.org/r/#/c/322812/ - we'll need to get them fixed for jQuery 3

matthiasmullie claimed this task.May 5 2017, 3:57 PM
matthiasmullie moved this task from Backlog to In Process on the MediaViewer board.
gerritbot added a subscriber: gerritbot.May 5 2017, 5:58 PM

Change 352183 had a related patch set uploaded (by Matthias Mullie; owner: Matthias Mullie):
[mediawiki/extensions/MultimediaViewer@master] [WIP] Fix MMV qunit tests

https://gerrit.wikimedia.org/r/352183

gerritbot added a project: Patch-For-Review.May 5 2017, 5:58 PM
matthiasmullie merged a task: T164644: qunit test is failing for MultimediaViewer extension.May 8 2017, 9:08 AM
matthiasmullie added a subscriber: Umherirrender.
gerritbot added a comment.May 11 2017, 3:10 PM

Change 353307 had a related patch set uploaded (by Matthias Mullie; owner: Matthias Mullie):
[mediawiki/extensions/MultimediaViewer@master] Fix mmv unit tests

https://gerrit.wikimedia.org/r/353307

gerritbot added a comment.May 15 2017, 3:39 PM

Change 353886 had a related patch set uploaded (by Matthias Mullie; owner: Matthias Mullie):
[mediawiki/extensions/MultimediaViewer@master] Fix mmw.ui.metadataPanel qunit tests

https://gerrit.wikimedia.org/r/353886

gerritbot added a comment.May 15 2017, 3:39 PM

Change 353887 had a related patch set uploaded (by Matthias Mullie; owner: Matthias Mullie):
[mediawiki/extensions/MultimediaViewer@master] Fix mmv.model.TaskQueue qunit tests

https://gerrit.wikimedia.org/r/353887

gerritbot added a comment.May 15 2017, 3:39 PM

Change 353888 had a related patch set uploaded (by Matthias Mullie; owner: Matthias Mullie):
[mediawiki/extensions/MultimediaViewer@master] Fix mmv.logging.ViewLogger qunit tests

https://gerrit.wikimedia.org/r/353888

gerritbot added a comment.May 15 2017, 3:39 PM

Change 353889 had a related patch set uploaded (by Matthias Mullie; owner: Matthias Mullie):
[mediawiki/extensions/MultimediaViewer@master] Fix mmv.logging.ActionLogger qunit tests

https://gerrit.wikimedia.org/r/353889

gerritbot added a comment.May 15 2017, 3:39 PM

Change 353890 had a related patch set uploaded (by Matthias Mullie; owner: Matthias Mullie):
[mediawiki/extensions/MultimediaViewer@master] Fix mmv.logging.PerformanceLogger qunit tests

https://gerrit.wikimedia.org/r/353890

gerritbot added a comment.May 15 2017, 3:39 PM

Change 353891 had a related patch set uploaded (by Matthias Mullie; owner: Matthias Mullie):
[mediawiki/extensions/MultimediaViewer@master] Fix mmv.logging.DurationLogger qunit tests

https://gerrit.wikimedia.org/r/353891

gerritbot added a comment.May 16 2017, 2:41 PM

Change 353999 had a related patch set uploaded (by Matthias Mullie; owner: Matthias Mullie):
[mediawiki/extensions/MultimediaViewer@master] Fix mmv.lightboxInterface qunit tests

https://gerrit.wikimedia.org/r/353999

gerritbot added a comment.May 17 2017, 9:53 AM

Change 354102 had a related patch set uploaded (by Matthias Mullie; owner: Matthias Mullie):
[mediawiki/extensions/MultimediaViewer@master] Fix mmv.model.TaskQueue qunit tests

https://gerrit.wikimedia.org/r/354102

Esanders added a subscriber: Esanders.May 17 2017, 4:53 PM

Given these fixes are mostly the same - couldn't they be squashed into one commit?

gerritbot added a comment.May 18 2017, 3:21 PM

Change 352183 merged by Jforrester:
[mediawiki/extensions/MultimediaViewer@master] Fix mmv.bootstrap qunit tests

https://gerrit.wikimedia.org/r/352183

gerritbot added a comment.May 18 2017, 3:21 PM

Change 353307 merged by Jforrester:
[mediawiki/extensions/MultimediaViewer@master] Fix mmv qunit tests

https://gerrit.wikimedia.org/r/353307

gerritbot added a comment.May 18 2017, 3:22 PM

Change 353886 merged by Jforrester:
[mediawiki/extensions/MultimediaViewer@master] Fix mmw.ui.metadataPanel qunit tests

https://gerrit.wikimedia.org/r/353886

gerritbot added a comment.May 18 2017, 3:22 PM

Change 353887 merged by Jforrester:
[mediawiki/extensions/MultimediaViewer@master] Fix mmv.model.TaskQueue qunit tests

https://gerrit.wikimedia.org/r/353887

gerritbot added a comment.May 18 2017, 3:22 PM

Change 353888 merged by Jforrester:
[mediawiki/extensions/MultimediaViewer@master] Fix mmv.logging.ViewLogger qunit tests

https://gerrit.wikimedia.org/r/353888

gerritbot added a comment.May 18 2017, 3:23 PM

Change 353889 merged by Jforrester:
[mediawiki/extensions/MultimediaViewer@master] Fix mmv.logging.ActionLogger qunit tests

https://gerrit.wikimedia.org/r/353889

gerritbot added a comment.May 18 2017, 3:23 PM

Change 353890 merged by Jforrester:
[mediawiki/extensions/MultimediaViewer@master] Fix mmv.logging.PerformanceLogger qunit tests

https://gerrit.wikimedia.org/r/353890

gerritbot added a comment.May 18 2017, 3:24 PM

Change 353891 merged by Jforrester:
[mediawiki/extensions/MultimediaViewer@master] Fix mmv.logging.DurationLogger qunit tests

https://gerrit.wikimedia.org/r/353891

gerritbot added a comment.May 18 2017, 3:24 PM

Change 353999 merged by Jforrester:
[mediawiki/extensions/MultimediaViewer@master] Fix mmv.lightboxInterface qunit tests

https://gerrit.wikimedia.org/r/353999

gerritbot added a comment.May 18 2017, 3:51 PM

Change 354102 merged by jenkins-bot:
[mediawiki/extensions/MultimediaViewer@master] Fix mmv.model.TaskQueue qunit tests

https://gerrit.wikimedia.org/r/354102

ReleaseTaggerBot added a project: MW-1.30-release-notes (WMF-deploy-2017-05-23_(1.30.0-wmf.2)).May 18 2017, 4:00 PM
matthiasmullie closed this task as Resolved.May 23 2017, 9:57 AM
Content licensed under Creative Commons Attribution-ShareAlike 3.0 (CC-BY-SA) unless otherwise noted; code licensed under GNU General Public License (GPL) or other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL