Page MenuHomePhabricator
Create Task
Maniphest T164474

Icons in the jquery.ime selector are misaligned in RTL
Closed, ResolvedPublic
Actions

Description

Icons in the jquery.ime selector are misaligned in RTL:

rtl-ime-2.png (540×511 px, 42 KB)

Notice two RTL issues:

  • the keyboard at the top button.
  • the tick mark at the selected keyboard.

Details

SubjectRepoBranchLines +/-
Update jquery.ime from upstreammediawiki/extensions/UniversalLanguageSelectormaster+2 -5
Customize query in gerrit

Event Timeline

Amire80 created this task.May 4 2017, 10:54 AM
Restricted Application added a project: I18n. · View Herald TranscriptMay 4 2017, 10:54 AM
Restricted Application added subscribers: TerraCodes, Aklapper. · View Herald Transcript
Amire80 claimed this task.May 4 2017, 10:55 AM
Amire80 added a project: Patch-For-Review.

Upstream patch: https://github.com/wikimedia/jquery.ime/pull/475 .

Amire80 triaged this task as Low priority.May 4 2017, 10:55 AM
Amire80 added projects: Unplanned-Sprint-Work, Language-team April-June 2017 (Language-2017 Sprint 7).
Amire80 moved this task from Backlog to In Review on the Language-team April-June 2017 (Language-2017 Sprint 7) board.
Amire80 added a project: Essential-Work.
gerritbot subscribed.May 9 2017, 9:55 AM

Change 352773 had a related patch set uploaded (by Amire80; owner: Amire80):
[mediawiki/extensions/UniversalLanguageSelector@master] Update jquery.ime from upstream

https://gerrit.wikimedia.org/r/352773

• santhosh moved this task from In Review to QA on the Language-team April-June 2017 (Language-2017 Sprint 7) board.May 9 2017, 10:34 AM
gerritbot added a comment.May 9 2017, 10:43 AM

Change 352773 merged by jenkins-bot:
[mediawiki/extensions/UniversalLanguageSelector@master] Update jquery.ime from upstream

https://gerrit.wikimedia.org/r/352773

ReleaseTaggerBot added a project: MW-1.30-release-notes (WMF-deploy-2017-05-09_(1.30.0-wmf.1)).May 9 2017, 11:00 AM
Amire80 moved this task from QA to Done on the Language-team April-June 2017 (Language-2017 Sprint 7) board.May 15 2017, 12:48 PM

Deployed in train, verified in production. Thanks for the quick review.

Zppix moved this task from Backlog to Done on the good first task board.May 15 2017, 12:52 PM
Zppix moved this task from Backlog to Other on the RTL board.
Zppix moved this task from Other to ULS on the RTL board.
• santhosh closed this task as Resolved.May 16 2017, 6:40 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL