Page MenuHomePhabricator

OOUIHTMLForm should magically use a IndexLayout (OOUI tabs) and do the right thing on #displaySection() calls
Closed, DeclinedPublic

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMay 5 2017, 12:10 AM
matmarex claimed this task.Sep 6 2017, 10:05 PM
Ladsgroup renamed this task from OOUIHTMLForm should magically use use a TabLayout and do the right thing on #displaySection() calls to OOUIHTMLForm should magically use a TabLayout and do the right thing on #displaySection() calls.Sep 10 2017, 11:45 AM
matmarex closed this task as Declined.Sep 16 2017, 12:37 PM

I am currently implementing this specifically for the Special:Preferences form (see T117781), but I don't think we should do this for the general case of all OOUIHTMLForms.

There aren't many forms large enough to benefit from tabbed navigation, and frankly it is somewhat difficult to implement a generic way to do this with how annoyingly flexible HTMLForm is. When doing it only for a single form like Special:Preferences, we can make it easier by not handling certain corner cases that we know can never occur.

I'm willing to reconsider this if someone provides two more examples of forms where they'd like to use this. But until that happens, I think it would be unwise to spend time on a generic solution handling those corner cases.

matmarex renamed this task from OOUIHTMLForm should magically use a TabLayout and do the right thing on #displaySection() calls to OOUIHTMLForm should magically use a IndexLayout (OOUI tabs) and do the right thing on #displaySection() calls.Sep 16 2017, 12:59 PM