[1.29.0-wmf.21] RC filters - Monobook UI issues with highlights
Closed, ResolvedPublic3 Estimated Story Points
Actions

Assigned To

Authored By

	Etonkovidova
	May 5 2017, 12:17 AM

Description

Monobook, Safari 10:

Screen Shot 2017-05-04 at 5.14.10 PM.png (438×1 px, 105 KB)

Monobook Chrome:

Screen Shot 2017-05-04 at 5.12.13 PM.png (450×848 px, 95 KB)

Details

Related Changes in Gerrit:

Subject	Repo	Branch	Lines +/-
RC filters - Monobook UI issues with highlights	mediawiki/core	master	+3 -0
Update OOUI to v0.52.0	mediawiki/core	master	+289 -126
Apex theme: Workaround for ButtonWidget inside DecoratedOptionWidget	oojs/ui	master	+10 -0
OptionWidget: Use parent selector for icon/indicator/label styles	oojs/ui	master	+3 -3
MenuSelectWidgets: Don't unconditionally hide all descendant inputs	oojs/ui	master	+0 -8

Customize query in gerrit

Related Objects

Mentioned In: T209546: [wmf.4 -regression] Monobook - RC/Watchlist highlight icons misalgned
T168761: RC filters doesn't look so good outside of Vector/WikimediaUI
T165444: [betalabs-regression] monobook: Highlight button displays checkmark
T165446: [betalabs-regression] monobook: cannot de-select a selected filter
T164350: [regression wmf.21] Unwatch icon not visible on Monobook
Mentioned Here: T209546: [wmf.4 -regression] Monobook - RC/Watchlist highlight icons misalgned
T396350: Tag question-mark icons on Monobook RecentChanges extend beyond the box containing them (& are slightly vertically misaligned)
T165444: [betalabs-regression] monobook: Highlight button displays checkmark
T165446: [betalabs-regression] monobook: cannot de-select a selected filter

Event Timeline

Etonkovidova created this task.May 5 2017, 12:17 AM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMay 5 2017, 12:17 AM

Etonkovidova renamed this task from Rc filters - Monobook UI issues with highlights to RC filters - Monobook UI issues with highlights .May 5 2017, 12:18 AM

Etonkovidova renamed this task from RC filters - Monobook UI issues with highlights to [wmf.21] RC filters - Monobook UI issues with highlights .May 5 2017, 12:46 AM

Catrope moved this task from Untriaged to Ready for Pickup on the Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017) board.May 5 2017, 2:04 AM

Catrope set the point value for this task to 1.

Catrope added a subscriber: Mooeypoo.

Catrope mentioned this in T164350: [regression wmf.21] Unwatch icon not visible on Monobook.May 8 2017, 6:22 PM

Also checkboxes on the left side of names.

Change 352730 had a related patch set uploaded (by Catrope; owner: Catrope):
[oojs/ui@master] MenuSelectWidgets: Don't unconditionally hide all descendant inputs

https://gerrit.wikimedia.org/r/352730

gerritbot added a project: Patch-For-Review.May 9 2017, 12:00 AM

Change 352735 had a related patch set uploaded (by Catrope; owner: Catrope):
[oojs/ui@master] OptionWidget: Use parent selector for icon/indicator/label styles

https://gerrit.wikimedia.org/r/352735

With my patches it looks a lot better:

rcfilters-monobook-fixed.png (547×657 px, 64 KB)

There's still a discrepancy in the size of the highlight button when highlighting vs not, though:

rcfilters-monobook-highlight-buttons.png (276×112 px, 4 KB)

Change 352730 merged by jenkins-bot:
[oojs/ui@master] MenuSelectWidgets: Don't unconditionally hide all descendant inputs

https://gerrit.wikimedia.org/r/352730

Change 352735 merged by jenkins-bot:
[oojs/ui@master] OptionWidget: Use parent selector for icon/indicator/label styles

https://gerrit.wikimedia.org/r/352735

This seems to be fixed, unless I'm missing something?

(There are other bugs related to the highlight menu + 'checkmark' issue in monobook, but they're dealt with in another task).

Is there anything still missing on this one that isn't covered by T165446: [betalabs-regression] monobook: cannot de-select a selected filter and T165444: [betalabs-regression] monobook: Highlight button displays checkmark ? or are we just waiting on OOUI release to move it to QA?

In T164550#3297770, @Mooeypoo wrote:

This seems to be fixed, unless I'm missing something?

(There are other bugs related to the highlight menu + 'checkmark' issue in monobook, but they're dealt with in another task).

Is there anything still missing on this one that isn't covered by T165446: [betalabs-regression] monobook: cannot de-select a selected filter and T165444: [betalabs-regression] monobook: Highlight button displays checkmark ? or are we just waiting on OOUI release to move it to QA?

I wrote:

There's still a discrepancy in the size of the highlight button when highlighting vs not, though:

Is that now fixed too?

As far as I can tell, not only is this not fixed, the checkmarks have become misaligned (possibly as a result of @Mooeypoo's patch to make them aligned in Vector?)

rcfilters-monobook-highlights.png (264×338 px, 11 KB)

Etonkovidova mentioned this in T165446: [betalabs-regression] monobook: cannot de-select a selected filter .Jun 6 2017, 7:05 AM

Etonkovidova mentioned this in T165444: [betalabs-regression] monobook: Highlight button displays checkmark.Jun 6 2017, 7:39 AM

Etonkovidova mentioned this in T168761: RC filters doesn't look so good outside of Vector/WikimediaUI.Jun 30 2017, 5:53 PM

• jmatazzoni edited projects, added Collaboration-Team-Triage (Collab-Team-This-Quarter); removed Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017).Jul 12 2017, 9:59 PM

• jmatazzoni moved this task from Untriaged to Ready for Pickup on the Collaboration-Team-Triage (Collab-Team-This-Quarter) board.Jul 12 2017, 10:23 PM

• jmatazzoni edited projects, added Collaboration-Team-Triage; removed Collaboration-Team-Triage (Collab-Team-This-Quarter).Oct 11 2017, 7:19 PM

• jmatazzoni moved this task from Untriaged to Medium-Term Interest on the Collaboration-Team-Triage board.

Etonkovidova mentioned this in T209546: [wmf.4 -regression] Monobook - RC/Watchlist highlight icons misalgned.Nov 14 2018, 11:02 PM

Aklapper edited projects, added Growth-Team; removed Collaboration-Team-Triage.Oct 12 2019, 4:08 AM

MBinder_WMF added a project: Growth-Team-Filtering.Apr 15 2021, 6:56 PM

Pppery removed a project: Patch-For-Review.Apr 1 2023, 7:47 PM

C.Ezra.M subscribed.Apr 26 2025, 3:38 PM

(boldly resetting the estimated story points field, as it seems like this might need re-estimation prior to being worked on again)

Restricted Application added a project: Moderator-Tools-Team. · View Herald TranscriptMay 16 2025, 11:51 AM

Kgraessle moved this task from Inbox to Design backlog on the Moderator-Tools-Team board.May 22 2025, 5:15 PM

Kgraessle moved this task from Design backlog to To be estimated on the Moderator-Tools-Team board.

The current check in beta labs shows that there are some improvements

x in filters' bubbles are aligned properly
the checkboxes are present
the pencil icon look/scale is improved

Screen Shot 2025-05-23 at 3.54.38 PM.png (1×1 px, 270 KB)

As far as I can see, the fix remaining for this task (that hasn't been applied through other patches/tasks, e.g. T209546: [wmf.4 -regression] Monobook - RC/Watchlist highlight icons misalgned) might be the slight misalignment of the 'tick' icon within the "select a color" dialog (ref. T164550#3317014):

screenshot-monobook-color-selection.png (141×340 px, 7 KB)

There's another thing I noticed that could potentially be a design bug, but I'm not familiar enough with MonoBook/the RecentChanges design to say one way or the other for certain: is there enough padding to the left of the highlighter button that appears on each row, & should the down-indicator icon be vertically centered within the button (or is it intended to be near the bottom)?

screenshot-monobook-highlight-button-padding.png (95×104 px, 2 KB)

While checking RecentChanges in Monobook, I also noticed something else -- when viewing the 'Tags' menu, the question-mark icon overlaps with the highlighting button (& is slightly vertically misaligned). That also seems to occur when not using the highlighting feature, though, so I've split that out to its own task: T396350: Tag question-mark icons on Monobook RecentChanges extend beyond the box containing them (& are slightly vertically misaligned).

screenshot-monobook-tag-menu-overlap.png (163×651 px, 17 KB)

@Etonkovidova (or anyone else) — is there anything else that you're aware about that I've missed from this?

Change #1154902 had a related patch set uploaded (by Bartosz Dziewoński; author: Bartosz Dziewoński):

[oojs/ui@master] Apex theme: Workaround for ButtonWidget inside DecoratedOptionWidget

https://gerrit.wikimedia.org/r/1154902

gerritbot added a project: Patch-For-Review.Jun 9 2025, 11:17 PM

Change #1154902 merged by jenkins-bot:

[oojs/ui@master] Apex theme: Workaround for ButtonWidget inside DecoratedOptionWidget

https://gerrit.wikimedia.org/r/1154902

Maintenance_bot removed a project: Patch-For-Review.Jun 10 2025, 12:31 PM

Scardenasmolinar moved this task from To be estimated to Estimated on the Moderator-Tools-Team board.Jun 10 2025, 3:28 PM

Scardenasmolinar set the point value for this task to 3.

DMburugu moved this task from Estimated to Kanban on the Moderator-Tools-Team board.Jun 10 2025, 4:08 PM

DMburugu edited projects, added Moderator-Tools-Team (Kanban); removed Moderator-Tools-Team.

DMburugu triaged this task as Medium priority.Jun 10 2025, 4:13 PM

In T164550#10895359, @A_smart_kitten wrote:

There's another thing I noticed that could potentially be a design bug, but I'm not familiar enough with MonoBook/the RecentChanges design to say one way or the other for certain: is there enough padding to the left of the highlighter button that appears on each row, & should the down-indicator icon be vertically centered within the button (or is it intended to be near the bottom)?

In T164550#10895359, @A_smart_kitten wrote:

While checking RecentChanges in Monobook, I also noticed something else -- when viewing the 'Tags' menu, the question-mark icon overlaps with the highlighting button (& is slightly vertically misaligned). That also seems to occur when not using the highlighting feature, though, so I've split that out to its own task: T396350: Tag question-mark icons on Monobook RecentChanges extend beyond the box containing them (& are slightly vertically misaligned).

These two issues will be resolved by my patch; the rest of them still stand.

I'm not sure if anyone cares about the misalignment. Personally I would suggest closing this.

Change #1156368 had a related patch set uploaded (by VolkerE; author: VolkerE):

[mediawiki/core@master] Update OOUI to v0.52.0

https://gerrit.wikimedia.org/r/1156368

gerritbot added a project: Patch-For-Review.Jun 12 2025, 2:29 PM

Change #1156368 merged by jenkins-bot:

[mediawiki/core@master] Update OOUI to v0.52.0

https://gerrit.wikimedia.org/r/1156368

Maintenance_bot removed a project: Patch-For-Review.Jun 13 2025, 4:32 PM

Kgraessle claimed this task.Jun 20 2025, 4:22 PM

Kgraessle moved this task from Ready to In Progress on the Moderator-Tools-Team (Kanban) board.

Change #1163038 had a related patch set uploaded (by Kgraessle; author: Kgraessle):

[mediawiki/core@master] RC filters - Monobook UI issues with highlights

https://gerrit.wikimedia.org/r/1163038

gerritbot added a project: Patch-For-Review.Jun 23 2025, 9:33 PM

Test wiki created on Patch demo by KGraessle-WMF using patch(es) linked to this task:
https://patchdemo.wmcloud.org/wikis/092a75f0bf/w/

Test wiki on Patch demo by KGraessle-WMF using patch(es) linked to this task was deleted:

~~https://patchdemo.wmcloud.org/wikis/092a75f0bf/w/~~

Test wiki created on Patch demo by KGraessle-WMF using patch(es) linked to this task:
https://patchdemo.wmcloud.org/wikis/d2d7e8b405/w/

Kgraessle moved this task from In Progress to Eng review on the Moderator-Tools-Team (Kanban) board.Jun 24 2025, 3:29 PM

Change #1163038 merged by jenkins-bot:

[mediawiki/core@master] RC filters - Monobook UI issues with highlights

https://gerrit.wikimedia.org/r/1163038

Scardenasmolinar moved this task from Eng review to QA on the Moderator-Tools-Team (Kanban) board.Jun 24 2025, 8:45 PM

ReleaseTaggerBot added a project: MW-1.45-notes (1.45.0-wmf.8; 2025-07-01).Jun 24 2025, 9:00 PM

Test wiki on Patch demo by KGraessle-WMF using patch(es) linked to this task was deleted:

~~https://patchdemo.wmcloud.org/wikis/d2d7e8b405/w/~~

Maintenance_bot removed a project: Patch-For-Review.Jun 24 2025, 9:33 PM

Changes look to be working on testwiki.

	F62270369: screenshot-monobook-tag-menu-overlap.png
	Jun 9 2025, 1:16 PM

	F62273527: screenshot-monobook-highlight-button-padding.png
	Jun 9 2025, 1:16 PM

	F62268906: screenshot-monobook-color-selection.png
	Jun 9 2025, 1:16 PM

	F60429190: Screen Shot 2025-05-23 at 3.54.38 PM.png
	May 23 2025, 10:56 PM

	F8388057: rcfilters-monobook-highlights.png
	Jun 5 2017, 11:55 PM

	F7989751: rcfilters-monobook-highlight-buttons.png
	May 9 2017, 12:49 AM

	F7919948: Screen Shot 2017-05-04 at 5.12.13 PM.png
	May 5 2017, 12:17 AM

[1.29.0-wmf.21] RC filters - Monobook UI issues with highlightsClosed, ResolvedPublic3 Estimated Story PointsActions

Description

Details

Related Objects

Event Timeline

[1.29.0-wmf.21] RC filters - Monobook UI issues with highlights
Closed, ResolvedPublic3 Estimated Story Points
Actions