Page offline error message appears
Page is loaded
App version: master
Android OS versions: 4.4 Kitkat (CM 11), 7.1.2 Nougat
Device model: Samsung Galaxy SIII, Nexus 6P
Device language: en
Change 352859 had a related patch set uploaded (by Dbrant; owner: Dbrant):
[apps/android/wikipedia@master] Trigger saving/unsaving of page upon toggle.
Change 352859 merged by jenkins-bot:
[apps/android/wikipedia@master] Trigger saving/unsaving of page upon toggle.
Tested on Nexus 4 with Android 5.1 and Pixel with Android 7.1 on 2.5.195-alpha-2017-06-05
I am having some issues reproducing the scenario above. Here is what I tried:
Installed the app
In this case, The article opens normally, but it seems like they should not. @Dbrant, do these steps make sense?
Yep, confirmed it's still broken per the instructions from @ABorbaWMF, at least according to my understanding of how the caches are intended to work. Removing from offline should blow away any trace of the article from storage.
Well, hang on now:
Even if you remove a page from offline availability, it may still be present in the main OkHttp cache (as opposed to the saved-page cache), and would therefore still be accessible offline. I think an additional step for testing this would need to be:
It used to be that the page was cleared from both caches. Maybe this has changed? The article remaining in HTTP cache is arguably what should happen, just not what's intended to happen, as best I can recall from last time we all discussed it.
Looking at SavedPageSyncService, though, it's only touching the SAVE_CACHE, so this could be working as intended after all.
Indeed; and I think that's actually how it should be -- allow OkHttp to manage its primary cache the way it wants, and only apply our custom logic to our own custom cache.
While working on T166596 I confirmed in the debugger that pages are indeed remaining in the save cache.
Repro steps:
The page should no longer be present, but it's still there; and I confirmed from debugging CacheDelegateInterceptor that it's coming from the save cache.
Change 378338 had a related patch set uploaded (by Mholloway; owner: Mholloway):
[apps/android/wikipedia@master] Fix: Clear deleted offline pages from the save cache
Change 378715 had a related patch set uploaded (by Dbrant; owner: Dbrant):
[apps/android/wikipedia@master] Fix: make sure page contents are deleted from disk when deleting from list.
Change 378338 abandoned by Mholloway:
Fix: Clear deleted offline pages from the save cache
Reason:
see Iba7004
Change 378715 merged by jenkins-bot:
[apps/android/wikipedia@master] Fix: make sure page contents are deleted from disk when deleting from list.
Tested on a Nexus 4 with Android 5.1 and a Pixel with Android 7.1.1 on 2.6.203-alpha-2017-09-18
Looked at it again and confirmed. Ready for sign-off