Page MenuHomePhabricator

Fix alignment constraint check notification headline and close button
Closed, ResolvedPublic

Description

Currently headline and close button look like

image.png (118×405 px, 6 KB)

It should look like

image.png (174×455 px, 15 KB)

Related Objects

View Standalone Graph
This task is connected to more than 200 other tasks. Only direct parents and subtasks are shown here. Use View Standalone Graph to show more of the graph.

Event Timeline

Lucas_Werkmeister_WMDE renamed this task from Fix Alignment Chonstraing check notification headline and close button to Fix alignment constraint check notification headline and close button .May 9 2017, 12:44 PM

I’m not sure exactly what you mean. I can remove the padding-top and margin-top from the “Potential issues” headline (but not the “single value” headline, right?), but what’s wrong with the close button?

I suppose this shows it better:

before

image.png (64×220 px, 11 KB)

maybe after
image.png (93×399 px, 6 KB)

Is this better? I’ve removed the padding+margin from the h4 itself, the rest is OO.ui margin on the popup label.

image.png (179×437 px, 10 KB)

Change 352857 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Lucas Werkmeister (WMDE)):
[mediawiki/extensions/WikibaseQualityConstraints@master] Remove padding and margin from top of heading

https://gerrit.wikimedia.org/r/352857

Change 353017 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Lucas Werkmeister (WMDE)):
[mediawiki/extensions/WikibaseQualityConstraints@master] Add margin to popup close button

https://gerrit.wikimedia.org/r/353017

Change 352857 abandoned by Lucas Werkmeister (WMDE):
Remove padding and margin from top of heading

Reason:
Superseded by I08e1fe23473d5a0966f542031664dd7424f9bb1c.

https://gerrit.wikimedia.org/r/352857

Change 353017 abandoned by Lucas Werkmeister (WMDE):
Add margin to popup close button

Reason:
Superseded by I08e1fe23473d5a0966f542031664dd7424f9bb1c.

https://gerrit.wikimedia.org/r/353017