Page MenuHomePhabricator

Cumin: allow to specify a timeout per command
Closed, ResolvedPublic

Description

As of now Cumin allow only to specify a global timeout for the whole execution. A much more useful feature is to be able to specify a timeout for each command in each host.

The idea is to use the existing -t TIMEOUT, --timeout TIMEOUT option for the new feature that will probably be used more often, and move the current global timeout feature to something like --global-timeout.

From the library it will be possible to specify the timeout for each command, from the CLI I'm on the fence between a simple solution like -t 5 that applies the same timeout to all commands (thanks @elukey) or make it a bit more complex syntax to allow to specify it for each one, like -t 5,0,23.

Event Timeline

Change 352841 had a related patch set uploaded (by Volans; owner: Volans):
[operations/software/cumin@master] Transports: move BaseWorker helper methods to module functions

https://gerrit.wikimedia.org/r/352841

Change 352842 had a related patch set uploaded (by Volans; owner: Volans):
[operations/software/cumin@master] Transports: add Command class

https://gerrit.wikimedia.org/r/352842

Change 352843 had a related patch set uploaded (by Volans; owner: Volans):
[operations/software/cumin@master] Transports: use Command class for commands

https://gerrit.wikimedia.org/r/352843

Change 352844 had a related patch set uploaded (by Volans; owner: Volans):
[operations/software/cumin@master] Transports: allow to specify a timeout per Command

https://gerrit.wikimedia.org/r/352844

Change 352845 had a related patch set uploaded (by Volans; owner: Volans):
[operations/software/cumin@master] Transports: allow to specify exit codes per Command

https://gerrit.wikimedia.org/r/352845

Change 352841 merged by jenkins-bot:
[operations/software/cumin@master] Transports: move BaseWorker helper methods to module functions

https://gerrit.wikimedia.org/r/352841

Change 352842 merged by jenkins-bot:
[operations/software/cumin@master] Transports: add Command class

https://gerrit.wikimedia.org/r/352842

Change 352843 merged by jenkins-bot:
[operations/software/cumin@master] Transports: use Command class for commands

https://gerrit.wikimedia.org/r/352843

Change 352844 merged by jenkins-bot:
[operations/software/cumin@master] Transports: allow to specify a timeout per Command

https://gerrit.wikimedia.org/r/352844

Change 352845 merged by jenkins-bot:
[operations/software/cumin@master] Transports: allow to specify exit codes per Command

https://gerrit.wikimedia.org/r/352845

Change 359466 had a related patch set uploaded (by Volans; owner: Volans):
[operations/software/cumin@master] ClusterShell: allow to set a timeout per command

https://gerrit.wikimedia.org/r/359466

Change 359467 had a related patch set uploaded (by Volans; owner: Volans):
[operations/software/cumin@master] CLI: migrate to timeout per command

https://gerrit.wikimedia.org/r/359467

Change 359466 merged by jenkins-bot:
[operations/software/cumin@master] ClusterShell: allow to set a timeout per command

https://gerrit.wikimedia.org/r/359466

Change 359467 merged by jenkins-bot:
[operations/software/cumin@master] CLI: migrate to timeout per command

https://gerrit.wikimedia.org/r/359467

Volans moved this task from In Code Review to Done on the SRE-tools board.
Volans removed a project: Patch-For-Review.