Page MenuHomePhabricator
Create Task
Maniphest T164896

Restore compat with 'LBFactory' type hint for \Wikimedia\Rdbms\LBFactory in 1.29
Closed, ResolvedPublic
Actions

Description

Doing a is_a($lbfactory, \LBFactory) no longer works in 1.29+. It seems \Wikimedia\Rdbms\LBFactory does not define a class_alias and while the use of namespaced classes is appreciated, please wait at least until the next LTS release before removing interfaces and classes otherwise you are inviting unnecessary failures for extensions that need to support 1.27+.

Details

ProjectBranchLines +/-Subject
mediawiki/coreREL1_29+3 -0rdbms: Add compat alias for renamed LBFactory class
mediawiki/coremaster+3 -0rdbms: Add compat alias for renamed LBFactory class
Customize query in gerrit

Related Objects

Event Timeline

mwjames created this task.May 10 2017, 3:28 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMay 10 2017, 3:28 AM
Krinkle claimed this task.May 24 2017, 11:26 AM
Krinkle triaged this task as High priority.
Krinkle moved this task from Untriaged to Rdbms library on the Wikimedia-Rdbms board.
Krinkle added projects: MW-1.29-release, Performance-Team.
Krinkle renamed this task from 1.29+ / Class 'LBFactory' not found, type hint on \LBFactory no longer works and requires \Wikimedia\Rdbms\LBFactory instead to Restore compat with 'LBFactory' type hint for \Wikimedia\Rdbms\LBFactory in 1.29.May 24 2017, 11:29 AM
gerritbot added a subscriber: gerritbot.May 24 2017, 11:29 AM

Change 355422 had a related patch set uploaded (by Krinkle; owner: Krinkle):
[mediawiki/core@master] rdbms: Add compat alias for renamed LBFactory class

https://gerrit.wikimedia.org/r/355422

gerritbot added a project: Patch-For-Review.May 24 2017, 11:29 AM
gerritbot added a comment.May 24 2017, 3:53 PM

Change 355422 merged by jenkins-bot:
[mediawiki/core@master] rdbms: Add compat alias for renamed LBFactory class

https://gerrit.wikimedia.org/r/355422

ReleaseTaggerBot added a project: MW-1.30-release-notes (WMF-deploy-2017-05-30_(1.30.0-wmf.3)).May 24 2017, 4:00 PM
gerritbot added a comment.May 25 2017, 12:52 PM

Change 355610 had a related patch set uploaded (by Krinkle; owner: Krinkle):
[mediawiki/core@REL1_29] rdbms: Add compat alias for renamed LBFactory class

https://gerrit.wikimedia.org/r/355610

Krinkle closed this task as Resolved.May 25 2017, 12:53 PM
gerritbot added a comment.May 25 2017, 1:01 PM

Change 355610 merged by jenkins-bot:
[mediawiki/core@REL1_29] rdbms: Add compat alias for renamed LBFactory class

https://gerrit.wikimedia.org/r/355610

ReleaseTaggerBot added a project: MW-1.29-release-notes.May 25 2017, 2:00 PM
Jdforrester-WMF edited projects, added MW-1.30-release-notes (WMF-deploy-2017-06-06_(1.30.0-wmf.4)); removed MW-1.30-release-notes (WMF-deploy-2017-05-30_(1.30.0-wmf.3)).Jun 6 2017, 8:37 PM
Jdforrester-WMF added a subscriber: Jdforrester-WMF.

Mass-moving all items tagged for MediaWiki 1.30.0-wmf.3, as that was never released; instead, we're using -wmf.4.

Seb35 mentioned this in T166738: Error "Class 'MWTimestamp' not found" when upgrading to MW 1.29.0-rc.0.Jun 16 2017, 1:51 PM
Content licensed under Creative Commons Attribution-ShareAlike 3.0 (CC-BY-SA) unless otherwise noted; code licensed under GNU General Public License (GPL) or other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL