Page MenuHomePhabricator

Change incorrect informations on the login form of phab-01.wmflabs.org
Closed, ResolvedPublic

Description

Why https://phab.wmflabs.org/auth/loggedout/ shows this message ?

Log in or register to Wikimedia Phabricator

Click the MediaWiki button below to connect your Wikimedia unified account.
Alternatively, you can introduce your Labs/Gerrit LDAP credentials.

These three lines are wrong. User must understand that he is not on the real WMF phabricator website and that he should not enter his real credentials in this window.

Event Timeline

Framawiki renamed this task from Change incorrect informations on phab-01.wmflabs.org to Change incorrect informations on the login form of phab-01.wmflabs.org.May 11 2017, 4:15 PM
Aklapper raised the priority of this task from High to Needs Triage.May 11 2017, 5:18 PM

Resetting task priority.

Why https://phab-01.wmflabs.org/auth/loggedout/ shows this message ?

Because it's a test instance where (ideally) the same code as on production is deployed?

User must understand that he is not on the real WMF phabricator website and that he should not enter his real credentials in this window.

While that is true, the instructions are already wrong enough (there is no "MediaWiki button") and don't make much sense anyway.

Resetting task priority.

Why https://phab-01.wmflabs.org/auth/loggedout/ shows this message ?

Because it's a test instance where (ideally) the same code as on production is deployed?

User must understand that he is not on the real WMF phabricator website and that he should not enter his real credentials in this window.

While that is true, the instructions are already wrong enough (there is no "MediaWiki button") and don't make much sense anyway.

Yep, it runs the same code as prod. This way we can catch things before they cause problems in prod.

But are you agree that user can try to login with his LDAP credentials ?
Is there any way to force the message after puppet has worked, or hard-code it somewhere ?

The current text on https://phab.wmflabs.org/auth/loggedout/ is different from a standard phabricator instance, so presumably this is done somewhere in a puppet manifest. That manifest could switch based on prod vs labs to change the text shown.

I remember that somewhere was written that as common security rule development environments (and beta ones can be considerate as such for me) should not be confused with production ones.

Resetting task priority.

Why https://phab-01.wmflabs.org/auth/loggedout/ shows this message ?

Because it's a test instance where (ideally) the same code as on production is deployed?

As said by @valhallasw just above beta cluster uses in majority production config and repos. A switch in puppet files can change a configuration line depending on if this will be prod or beta env.

taavi subscribed.

This seems to have been fixed.