#0 /srv/mediawiki/php-1.30.0-wmf.1/includes/libs/rdbms/database/Database.php(1312): Wikimedia\Rdbms\Database->makeList(array, integer) #1 /srv/mediawiki/php-1.30.0-wmf.1/includes/api/ApiQueryRevisions.php(237): Wikimedia\Rdbms\Database->selectSQLText(string, string, array, string) #2 /srv/mediawiki/php-1.30.0-wmf.1/includes/api/ApiQueryRevisionsBase.php(43): ApiQueryRevisions->run() #3 /srv/mediawiki/php-1.30.0-wmf.1/includes/api/ApiQuery.php(253): ApiQueryRevisionsBase->execute() #4 /srv/mediawiki/php-1.30.0-wmf.1/includes/api/ApiMain.php(1578): ApiQuery->execute() #5 /srv/mediawiki/php-1.30.0-wmf.1/includes/api/ApiMain.php(545): ApiMain->executeAction() #6 /srv/mediawiki/php-1.30.0-wmf.1/includes/api/ApiMain.php(516): ApiMain->executeActionWithErrorHandling() #7 /srv/mediawiki/php-1.30.0-wmf.1/api.php(83): ApiMain->execute() #8 /srv/mediawiki/w/api.php(3): include(string) #9 {main}
Description
Details
Status | Subtype | Assigned | Task | ||
---|---|---|---|---|---|
Resolved | thcipriani | T163512 MW-1.30.0-wmf.2 deployment blockers | |||
Resolved | PRODUCTION ERROR | Anomie | T165100 Wikimedia\Rdbms\Database::makeList: empty input for field rev_id |
Event Timeline
This is happening quite a lot in production but I haven't yet isolated what is causing it.
Per https://github.com/wikimedia/mediawiki/commits/wmf/1.30.0-wmf.1/includes/api/ApiQueryRevisions.php, most likely one of these two:
- rMW09736bd00d0b: ApiQueryRevisions: Restore use of rvstartid/rvendid as a tiebreaker
- rMWe72256a6d970: API: Convert rvstartid/rvendid to timestamps for query
Probably the latter (rMWe72256)
$db->selectSQLText( 'revision', [ 'id' => 'rev_id', 'ts' => 'rev_timestamp' ], [ 'rev_id' => $ids ], __METHOD__ ),
At first glance searching this in Kibana, it seems likely it's one client hammering failing queries. Working on it.
Change 353477 had a related patch set uploaded (by Anomie; owner: Anomie):
[mediawiki/core@master] ApiQueryRevisions: Don't be so tricky handling rvstartid/rvendid
@Anomie: agree, it's not very high frequency.
Failing url:
But if you remove the rvstart=0 parameter, then it works:
Change 353477 merged by jenkins-bot:
[mediawiki/core@master] ApiQueryRevisions: Don't be so tricky handling rvstartid/rvendid
Change 353906 had a related patch set uploaded (by Catrope; owner: Anomie):
[mediawiki/core@wmf/1.30.0-wmf.1] ApiQueryRevisions: Don't be so tricky handling rvstartid/rvendid
Change 353906 merged by jenkins-bot:
[mediawiki/core@wmf/1.30.0-wmf.1] ApiQueryRevisions: Don't be so tricky handling rvstartid/rvendid
Mentioned in SAL (#wikimedia-operations) [2017-05-15T19:42:29Z] <catrope@tin> Synchronized php-1.30.0-wmf.1/includes/api/ApiQueryRevisions.php: T165100 (duration: 00m 40s)