Page MenuHomePhabricator

'Quick links' - blank names for saved filters
Closed, ResolvedPublic


  1. On RC page select some filters and click the 'Quick links' button
  2. For the name of a filter press spacebar several times - the blank name will be saved.

Screen Shot 2017-05-11 at 4.53.57 PM.png (301×381 px, 19 KB)

Event Timeline


You know, @Etonkovidova, I've tried to set up guards against empty strings, and nulls, and make sure nothing can be saved if it's empty -- and the thought that someone would put in several spaces as a name to cheat the system into saving an empty query seriously never occurred to me.

My faith in humanity is inversely proportional to my faith in your ability to find the weirdest user-behavior available.

Change 353488 had a related patch set uploaded (by Mooeypoo; owner: Mooeypoo):
[mediawiki/core@master] RCFilters: Treat saved query with multiple spaces as empty

Change 353488 merged by jenkins-bot:
[mediawiki/core@master] RCFilters: Treat saved query with multiple spaces as empty

Check in betalabs - the issue is fixed:

  • not possible to save blank filter names
  • leading/trailing spaces spaces are truncated, including extra spaces between words (e.g. 'test[3 spaces] 1' will become 'test 1'

QA Recommendation: Resolve