Page MenuHomePhabricator
Create Task
Maniphest T165146

veaction=editsource in the URL should load new wikitext editor
Closed, ResolvedPublic1 Estimated Story Points
Actions

Description

Opening an URL like https://www.mediawiki.org/w/index.php?title=Template:Extension&veaction=editsource should load the NWE but doesn't. Besides linking, this also breaks middle-click usage patterns.

Details

SubjectRepoBranchLines +/-
Do not check for visual editor availability when loading source editormediawiki/extensions/VisualEditorwmf/1.30.0-wmf.1+1 -1
Do not check for visual editor availability when loading source editormediawiki/extensions/VisualEditormaster+1 -1
Customize query in gerrit

Related Objects

Event Timeline

Tgr created this task.May 12 2017, 11:19 AM
Restricted Application added a project: VisualEditor. · View Herald TranscriptMay 12 2017, 11:19 AM
Restricted Application added a subscriber: • Aklapper. · View Herald Transcript
Tgr added a comment.May 12 2017, 11:21 AM

On the other hand action=edit does load it, which did not happen in the past... (which makes the old editor inaccessible, which forces me to opt out of beta since NWE is too bug to always rely on, especially on translated pages).

Izno closed this task as a duplicate of T165132: action=edit in URL doesn't load OWE when NWE is enabled.May 12 2017, 11:44 AM
Tgr mentioned this in T165132: action=edit in URL doesn't load OWE when NWE is enabled.May 13 2017, 8:03 AM
Jdforrester-WMF reopened this task as Open.May 15 2017, 9:13 AM
Jdforrester-WMF triaged this task as High priority.
Jdforrester-WMF moved this task from To Triage to TR0: Interrupt on the VisualEditor board.
Jdforrester-WMF set the point value for this task to 1.
Jdforrester-WMF subscribed.

Not a dupe.

https://www.mediawiki.org/wiki/Special:Random/Template?veaction=editsource doesn't work but https://www.mediawiki.org/wiki/Special:Random?veaction=editsource does. Odd.

Jdforrester-WMF raised the priority of this task from High to Unbreak Now!.May 15 2017, 9:16 AM
Restricted Application added subscribers: Jay8g, TerraCodes. · View Herald TranscriptMay 15 2017, 9:16 AM
Jdforrester-WMF added a comment.May 15 2017, 9:16 AM

Similarly https://cs.wikipedia.org/w/index.php?title=Asdasda&action=edit&redlink=1 doesn't trigger.

matmarex merged a task: T165389: Direct navigation to ?veaction=editsource (e.g. opening in a new tab) fails to load the editor.May 16 2017, 4:28 PM
matmarex added subscribers: • Whatamidoing-WMF, Schnark, Esanders, Framawiki.
matmarex subscribed.May 16 2017, 4:32 PM
In T165389#3266688, @Schnark wrote:

This only happens on pages where visual mode is not available, and doesn't happen when you select "Always give me the visual editor if possible" in your preferences.

matmarex claimed this task.May 16 2017, 4:47 PM
gerritbot subscribed.May 16 2017, 5:00 PM

Change 354020 had a related patch set uploaded (by Bartosz Dziewoński; owner: Bartosz Dziewoński):
[mediawiki/extensions/VisualEditor@master] Do not check for visual editor availability when loading source editor

https://gerrit.wikimedia.org/r/354020

gerritbot added a project: Patch-For-Review.May 16 2017, 5:00 PM
gerritbot added a comment.May 17 2017, 4:09 PM

Change 354020 merged by jenkins-bot:
[mediawiki/extensions/VisualEditor@master] Do not check for visual editor availability when loading source editor

https://gerrit.wikimedia.org/r/354020

Dvorapa subscribed.May 17 2017, 4:28 PM
gerritbot added a comment.May 17 2017, 4:47 PM

Change 354126 had a related patch set uploaded (by Jforrester; owner: Bartosz Dziewoński):
[mediawiki/extensions/VisualEditor@wmf/1.30.0-wmf.1] Do not check for visual editor availability when loading source editor

https://gerrit.wikimedia.org/r/354126

ReleaseTaggerBot added a project: MW-1.30-release-notes (WMF-deploy-2017-05-23_(1.30.0-wmf.2)).May 17 2017, 5:00 PM
gerritbot added a comment.May 17 2017, 6:27 PM

Change 354126 merged by jenkins-bot:
[mediawiki/extensions/VisualEditor@wmf/1.30.0-wmf.1] Do not check for visual editor availability when loading source editor

https://gerrit.wikimedia.org/r/354126

Jdforrester-WMF closed this task as Resolved.May 17 2017, 6:32 PM
Jdforrester-WMF removed a project: Patch-For-Review.
Restricted Application added a project: User-Ryasmeen. · View Herald TranscriptMay 17 2017, 6:32 PM
ReleaseTaggerBot edited projects, added MW-1.30-release-notes (WMF-deploy-2017-05-09_(1.30.0-wmf.1)); removed MW-1.30-release-notes (WMF-deploy-2017-05-23_(1.30.0-wmf.2)).May 17 2017, 7:00 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits