Page MenuHomePhabricator

Actions done on RC filters and what is stored in browser history doesn't match
Closed, DuplicatePublic

Description

A user reports that he has to do extra actions to go back in his browser history when he uses the filters.

I've done the following actions:

  1. go to RCs
  2. choose a filter by using the check mark
  3. highlight a filter
  4. Click on my browser's "go back" button (no highlighting)
  5. Click on my browser's "go back" button (nothing happen - surprise)
  6. Click on my browser's "go back" button (checked filter disappears)

What happens:

  1. go to RCs
  2. choose a filter by using the checkmark (one revision stored in browser's history)
  3. highlight a filter (two revisions stored in browser's history 1, 2)
  4. Click on my browser's "go back" button (no highlighting)
  5. Click on my browser's "go back" button (nothing happen)
  6. Click on my browser's "go back" button (checked filter disappears)

Tested on Chromium 58 and Firefox 53, on RC on English and French Wikipedia.

Event Timeline

Restricted Application added a project: Collaboration-Team-Triage. · View Herald TranscriptMay 12 2017, 4:03 PM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
Trizek-WMF updated the task description. (Show Details)May 12 2017, 4:04 PM
Etonkovidova added a comment.EditedJun 14 2017, 8:02 AM

(1) Regarding scenarios described - each click on a browser back button, 'rolls back' just one action performed by a user:

  • a user checks (select) a filter
  • a user applies highlight color to a filter

So, clicking the Back button will roll back first applied highlight, then selection of filter. Why at some point there will be no action after clicking on the button is another issue.

(2) the behavior of the browser Back button is even more puzzling on, e.g. Watchlist or Contributions page.

  • land on Main page
  • go to Watchlist page - change "Period of time to display" and click "Show"
  • click to Hide any option - click "Show"
  • click Back
  • nothing will be changed in selected options, but if "No changes during the given period match these criteria." was displayed as the result of selected options, so now a use will see some results.
  • click Back again - the previously hidden option becomes unhidden
  • click Back again - 'Main page' will be displayed.

(2) Re-checked T165230: [regression] Refreshing the page makes filters vanish - no regression of that particular issue.

Checked as part of the checking the fix for T167919: The 'back' button should go out of RCFilters and to the previous page - the behavior of 'Back' browser button on RC page is consistent now with the expected back/forward browser navigation.

QA Recommendation: Resolve