Top margin issues on enwiki main page
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	RHo
	May 15 2017, 10:59 AM

Description

Bug filed via OTRS: https://ticket.wikimedia.org/otrs/index.pl?Action=AgentTicketZoom;TicketID=9948597

Steps to reproduce

Tap on the "Today's featured page" widget to open the Main page in the app.

Expected

Main page opens as a new article tab showing page content is shown starting from just below the app bar, with "Today's featured article" as the first heading on the screen.

Actual

Top of the screen is obscured behind the app bar:

Screenshot_20170515-125408.png (1×1 px, 450 KB)

Note: when a new article tab is opened (not from the widget), the content is not obscured, but has a different issue in that there is too much space between the app bar and the start of the content:

Screenshot_20170515-125737.png (1×1 px, 245 KB)

Occurring on

Originally reported via OTRS, bug replicated on
Device = Pixel (Android 7.1.2)
Version = Wikipedia 2.5.195-alpha-2017-05-11

Details

Related Changes in Gerrit:

	Subject	Repo	Branch	Lines +/-
	Fix top padding when viewing Main Page.	apps/android/wikipedia	master	+7 -14

Customize query in gerrit

Event Timeline

RHo created this task.May 15 2017, 10:59 AM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMay 15 2017, 10:59 AM

RHo updated the task description. (Show Details)May 15 2017, 11:53 AM

• Mholloway subscribed.May 25 2017, 2:45 PM

• Mholloway renamed this task from BUG: When opening Today's Main page from the widget, top of Main page is cut-off to BUG: Main page display issues.May 25 2017, 2:48 PM

• Mholloway updated the task description. (Show Details)

• NHarateh_WMF moved this task from Needs Triage to Bug Backlog on the Wikipedia-Android-App-Backlog board.May 31 2017, 3:31 PM

Change 357596 had a related patch set uploaded (by Dbrant; owner: Dbrant):
[apps/android/wikipedia@master] Fix top padding when viewing Main Page.

https://gerrit.wikimedia.org/r/357596

gerritbot added a project: Patch-For-Review.Jun 7 2017, 1:12 PM

Change 357596 merged by jenkins-bot:
[apps/android/wikipedia@master] Fix top padding when viewing Main Page.

https://gerrit.wikimedia.org/r/357596

• Mholloway renamed this task from BUG: Main page display issues to Top margin issues on enwiki main page.Jun 7 2017, 3:13 PM

• Mholloway assigned this task to Dbrant.

• Mholloway edited projects, added Wikipedia-Android-App-Backlog (Android-app-release-v2.6.19x-Bermuda🌴); removed Wikipedia-Android-App-Backlog.

• Mholloway moved this task from To Do to QA Signoff on the Wikipedia-Android-App-Backlog (Android-app-release-v2.6.19x-Bermuda🌴) board.

• Mholloway updated the task description. (Show Details)Jun 7 2017, 3:16 PM

Tested on Samsung-SM-JI20A Galaxy Express 3 (Android 6.0.1) and Wikipedia app 2.6.198-alpha-2017-06-12. This seems fixed as I don't see any margin spacing issues in the screencaps below (compared to the previous examples above) but I will let the staff decide.

T165307 From Explorer page.png (800×480 px, 136 KB)

T165307 Article.png (800×480 px, 159 KB)

Tested on Nexus 4 with Android 5.1 and Pixel with Android 7.1 on 2.6.198-beta-2017-06-09

Looks fixed to me

Dbrant moved this task from Ready for Signoff to Done on the Wikipedia-Android-App-Backlog (Android-app-release-v2.6.19x-Bermuda🌴) board.Jun 13 2017, 3:21 PM

Dbrant closed this task as Resolved.Jun 13 2017, 3:22 PM

	F8447907: T165307 From Explorer page.png
	Jun 12 2017, 11:59 PM

	F8181015: Screenshot_20170429-130422.png
	May 25 2017, 2:48 PM

	F8082630: Screenshot_20170515-125737.png
	May 15 2017, 10:59 AM

	F8082627: Screenshot_20170515-125408.png
	May 15 2017, 10:59 AM

Top margin issues on enwiki main pageClosed, ResolvedPublicActions