Page MenuHomePhabricator
Create Task
Maniphest T165319

Call to undefined method Wikimedia\Rdbms\DBQueryError::getText() in MysqlInstaller.php
Closed, ResolvedPublic
Actions

Description

The try-catch clauses in MysqlInstaller.php attempt to use the method ->getText() from the class DBQueryError, but neither this class nor its parents do declare such method. Trying to run the installer fails with an error message from PHP:
PHP Fatal error: Call to undefined method Wikimedia\Rdbms\DBQueryError::getText() in /home/mwuser/mediawiki/includes/installer/MysqlInstaller.php on line 597
Edit: This also appears to be the case in MssqlInstaller.php

Steps to reproduce:

Try running install.php with the dbuser and dbpass flags set to a user that already exists, with installdbuser an installdbpass set as well.

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
installer: Replace bad calls to getText() on DBQueryError exceptionsmediawiki/coreREL1_29+6 -6
installer: Replace bad calls to getText() on DBQueryError exceptionsmediawiki/coremaster+6 -6
Customize query in gerrit

Event Timeline

Mainframe98 created this task.May 15 2017, 1:06 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMay 15 2017, 1:06 PM
Mainframe98 updated the task description. (Show Details)May 15 2017, 1:13 PM
Mainframe98 claimed this task.May 15 2017, 3:21 PM

I've fixed this by replacing the calls to getText() with getMessage() similar to how PostgresInstaller.php does this.

gerritbot subscribed.May 15 2017, 3:52 PM

Change 353894 had a related patch set uploaded (by Mainframe98; owner: Mainframe98):
[mediawiki/core@master] Replace calls to getText() on DBQueryError exceptions

https://gerrit.wikimedia.org/r/353894

gerritbot added a project: Patch-For-Review.May 15 2017, 3:52 PM
Mainframe98 updated the task description. (Show Details)May 15 2017, 5:01 PM
Mainframe98 updated the task description. (Show Details)May 15 2017, 7:14 PM
Krinkle moved this task from Untriaged to Usage problem on the MediaWiki-libs-Rdbms board.May 24 2017, 11:25 AM
gerritbot added a comment.May 24 2017, 11:34 AM

Change 353894 merged by jenkins-bot:
[mediawiki/core@master] installer: Replace bad calls to getText() on DBQueryError exceptions

https://gerrit.wikimedia.org/r/353894

ReleaseTaggerBot added a project: MW-1.30-release-notes.May 24 2017, 12:00 PM
gerritbot added a comment.May 24 2017, 6:36 PM

Change 355472 had a related patch set uploaded (by Chad; owner: Mainframe98):
[mediawiki/core@REL1_29] installer: Replace bad calls to getText() on DBQueryError exceptions

https://gerrit.wikimedia.org/r/355472

gerritbot added a comment.May 24 2017, 6:46 PM

Change 355472 merged by jenkins-bot:
[mediawiki/core@REL1_29] installer: Replace bad calls to getText() on DBQueryError exceptions

https://gerrit.wikimedia.org/r/355472

ReleaseTaggerBot added a project: MW-1.29-release-notes.May 24 2017, 7:00 PM
Krinkle closed this task as Resolved.Sep 27 2017, 10:59 PM
Krinkle removed a project: Patch-For-Review.
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits