Page MenuHomePhabricator

[Bug] Explore and Places labels in tab bar are not being translated to system language
Closed, ResolvedPublic

Description

IMG_2529.PNG (1×750 px, 731 KB)

Steps to reproduce
Switch system language to French
Switch preferred app language to French
Open app

Expected results
All of the UI elements should be in French

Actual results
All UI elements except for the Explore + Places tabs are presented in French

Event Timeline

JMinor subscribed.

Just missing some translations, in this case.

JoeWalsh subscribed.

@JMinor @cmadeo I see the issue now - I misread it as being the UI within the views, not the tab bar itself. Fixing.

Tested on iPhone 5s with iOS 10.2 on App version 5.5.0 (1142)

All of the cards on the explore page are in the correct language. I found a small issue with the 'because you read' cards where the originating article title is garbled. I tried on French and German. Screenshots below. @JoeWalsh, Let me know if we should open a new ticket.

image.png (638×360 px, 186 KB)
image.png (638×360 px, 186 KB)

  • edit - more detail

@abogala85 does that problem persist with 1145? I was unable to repro with the latest version. If it does persist, how long ago were the articles read?

Testing on iPhone 6s (iOS 10.3.2) and iPhone 7 (iOS 10.3.1). This is not perfect but better than before, the Explore tab is still in English but Places tab is in French according to the screencaps below.

T165426 iPhone 7 (iOS 10.3.1) Part 1.JPG (1×750 px, 135 KB)
T165426 iPhone 7 (iOS 10.3.1) Part 2.JPG (1×750 px, 228 KB)

Tested on iPhone 5s with iOS 10.2, and iPad Mini 2 Retina on 10.2.1 on App version 5.5.0 (1149)

Did a fresh install after changing the device's system language. Everything within the app was the correct language. Parts of Explore widget are in English, but I think that is a separate issue.