Page MenuHomePhabricator

Remove traces of MathJax from the Math extension
Closed, ResolvedPublic


If I understand T99369: Remove client-side MathJax rendering mode correctly, the Math extension doesn't support MathJax any longer. (Please correct me if I'm wrong.)

Here are a few things I found by simply running git grep -i jax:

There are, however, some traces of MathJax left in the Math extension's code:

  • Translatable messages: mw_math_latexml_jax and mw_math_mathjax. They should be simply deleted from en.json,and qqq.json, and the other languages will be auto-updated. (patch)
  • README mentions MathJax configuration.
  • A reference image for Special:MathStatus. Actually opening that page in the English Wikipedia says "Test Comparing the generated SVG with the reference failed."
  • Tests.
  • Remove $wgUseMathJax = true; from WMF's CommonSettings.php. (patch)

If MathJax is completely irrelevant for the Math extension, then I guess that the only results for git grep -i jax should be in the HISTORY file.

Event Timeline

Change 353967 had a related patch set uploaded (by Amire80; owner: Amire80):
[mediawiki/extensions/Math@master] Remove MathJax messages from en.json

Change 353971 had a related patch set uploaded (by Amire80; owner: Amire80):
[operations/mediawiki-config@master] Remove UseMathJax from CommonSettings.php

Change 353967 merged by jenkins-bot:
[mediawiki/extensions/Math@master] Remove MathJax messages from en.json

If MathJax is completely irrelevant for the Math extension

Since the math extension builds on mathjax for generating output (via mathjax-node in mathoid), it is probably still relevant.

Change 353971 merged by jenkins-bot:
[operations/mediawiki-config@master] Remove UseMathJax from CommonSettings.php

Mentioned in SAL (#wikimedia-operations) [2017-05-25T18:34:19Z] <thcipriani@tin> Synchronized wmf-config/CommonSettings.php: SWAT: [[gerrit:355114|Remove special Math extension settings for hewiki]] [[gerrit:353971|Remove UseMathJax from CommonSettings.php]] T165475 (duration: 00m 43s)

Physikerwelt claimed this task.
Physikerwelt added a subscriber: Physikerwelt.

I did run git grep -i jax and the remaining results are justified. Closing.

physikerwelt@x1:~/git/wikipedia/Math$ git grep -i jax
RELEASE-NOTES-3.0.0:* (T99369) Remove client-side MathJax support.
i18n/ksh.json:  "mw_math_mathml": "<i lang=\"en\" xml:lang=\"en\" dir=\"ltr\" title=\"Mathematical notations in web pages\">MathJax</i>, wann dat nit jeihd <i lang=\"en\" xml:lang=\"en\" dir=\"ltr\" title=\"Scalable Vector Graphics\">SVG</i> udder söns <i lang=\"en\" xml:lang=\"en\" dir=\"ltr\" title=\"Portable Network Graphics\">PNG</i> (för modärne Brauser un Wärkzüsch för der Zohjang)",
images/reference.svg:<svg xmlns:xlink="" width="5.099ex" height="2.343ex" style="vertical-align: -0.505ex;" viewBox="0 -791.3 2195.4 1008.6" xmlns="" role="math" aria-labelledby="MathJax-SVG-1-Title MathJax-SVG-1-Desc">
images/reference.svg: <title id="MathJax-SVG-1-Title">Equation</title>
images/reference.svg: <desc id="MathJax-SVG-1-Desc">a plus b</desc>
modules/ve-math/ve.ui.MWMathSymbols.css:        background-image: url( data:image/svg+xml, );
modules/ve-math/ve.ui.MWMathSymbols.css:        background-image: url( data:image/svg+xml, );
package-lock.json:                                      "integrity": "sha512-zjaXglF5nnWpsq470jSv6P9DwPvgLkuapYmfDm3JWOm0vkNTVF2tI4UrN2r6jH1qM/uc/WtxYY1hYoA2dOKj5w==",
src/MathHooks.php:              // 'MW_MATH_MATHJAX'     => 6
src/MathHooks.php:              // 'MW_MATH_LATEXML_JAX' => 8
tests/phpunit/MathHooksTest.php:                        'MW_MATH_MATHJAX'     => $default,
tests/phpunit/MathHooksTest.php:                        'MW_MATH_LATEXML_JAX' => $default,