Page MenuHomePhabricator
Create Task
Maniphest T165481

When add new form statement list should be rendered correctly
Closed, ResolvedPublic
Actions

Description

Currently, when one clicks add (Form) button, the added form contains text "Statements' section will be here" instead of actual statement list.

What expected is that instead of this text there should be statement list giving ability to add a statement to the new form.

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
Statement list on newly added formmediawiki/extensions/WikibaseLexememaster+29 -7
Make controller responsible for switching lexemeformview to edit modemediawiki/extensions/WikibaseLexememaster+4 -12
Lexeme serializer can serialize grammatical featuresmediawiki/extensions/WikibaseLexememaster+26 -1
JS Lexeme deserializer can deserialize grammatical featuresmediawiki/extensions/WikibaseLexememaster+2 -2
Customize query in gerrit

Related Objects
Search...

StatusSubtypeAssignedTask
 OpenNoneT194253 Configure the CI job that runs WikibaseLexeme's browser tests against test wikidata
 ResolvedAddshoreT168260 Deploy WikibaseLexeme extension on Wikimedia cluster
 ResolvedAddshoreT191457 Deploy WikibaseLexeme on www.wikidata.org
 ResolvedAddshoreT191458 Deploy WikibaseLexeme on test.wikidata.org
 ResolvedLydia_PintscherT168263 WikibaseLexeme functional baseline
 ResolvedLydia_PintscherT159703 [Tracking] Support for Forms and Senses
 ResolvedLydia_PintscherT150178 Wikidata 2017 Q2 goals
 ResolvedLydia_PintscherT169708 Wikidata 2017 Q3 goals
 ResolvedLydia_PintscherT160052 [Epic] Support for Forms
 ResolveddanielT160521 [Epic] Forms of a Lexeme (UI)
 ResolvedNoneT160520 [Story] Section header for Forms
 ResolvedthiemowmdeT161092 Create LexemeFormsView and use it in LexemeView
 ResolvedNoneT161093 Create browser tests for section header for forms
 Resolved• JonasT161201 Run browser tests in CI
 ResolvedLydia_PintscherT160522 [Story] List of Forms (UI)
 ResolveddanielT164743 [Story] Add Form to list of Forms (UI)
 ResolvedNoneT160524 [Story] Add Form to list of Forms (non-persistent)
 ResolvedthiemowmdeT161789 [Task] Introduce HTML templates infrastructure for Wikibase Lexeme
 ResolvedJakob_WMDET162254 [Task] Move existing HTML from views to templates.php
 ResolvedJakob_WMDET162338 Add browsertests for 'Add Form to list of Forms'
 ResolvedWMDE-leszekT162339 Create "formlist" widget for list of Forms
 ResolvedWMDE-leszekT162340 Implement Form widget
 ResolvedWMDE-leszekT162341 Create an "add" button to add a Form to a list of Forms and wire it to display "add Form"
 DuplicateNoneT162342 Make the "add" button display the "add Form" form
 ResolvedWMDE-leszekT162343 Make the "save" button add the new form to the list widget
ResolvedLydia_PintscherT173743 [Story] Representations of a Form
 ResolvedNoneT173744 persistently addable/editable/removable Representations of a Form via the UI (M)
 ResolvedLucas_Werkmeister_WMDET178389 Create API for updating Form descriptions
 ResolvedLydia_PintscherT160525 [Story] Grammatical Feature of a Form
 Resolved• Aleksey_WMDET162788 [Story] basic non-editable list of Grammatical Features of a Form
 ResolvedWMDE-leszekT162790 [Story] basic editable list of Grammatical Features of a Form
 Resolved• JonasT163971 Investigate what widget could be used to render the editable list of Grammatical Features of a Form
 Resolved• JonasT164361 Create MenuTagMultiselectWidget for Grammatical Feature List
 ResolvedJakob_WMDET163972 Create browser test for the editing the list of Grammatical Features of a Form feature
 Resolved• JonasT164471 Create jquery ui widget for Grammatical Feature List
 InvalidNoneT162797 [Story] Grammatical Forms look like faked statements
 ResolvedLydia_PintscherT163785 [Story] UX design for a Form's list of grammatical features
ResolvedNoneT173742 persistently editable Grammatical Feature of a Form via the UI (M)
 Resolved• Aleksey_WMDET176473 [Task] Split Lexeme serializer into ExternalSerializer and StorageSerializer
 ResolvedWMDE-leszekT184409 Create the API module allowing editing the representation, and the grammatical features of a Form (days: 4)
 ResolvedLydia_PintscherT184411 UI: Use the API to save edits of grammatical features of the form (days: 1)
 ResolvedNoneT184702 Set the edit summary when editing the representation and/or grammatical features of the form
 ResolvedLydia_PintscherT160526 [Story] List of Statements for a Form
 ResolvedNoneT164742 [Story] Add Form to list of Forms (persistent)
 ResolvedLadsgroupT182424 Diffs for statements, grammatical features and representations of a form (M) (days: 9)
 ResolvedLydia_PintscherT165588 tasks for lexicographical data support until Wikimania 2017
 ResolvedLydia_PintscherT163723 [Story] non-persistently editable statements on a Form
 Resolved• Aleksey_WMDET165481 When add new form statement list should be rendered correctly
 ResolvedJakob_WMDET165575 [Story] Multi-variant Representations (UI)

Event Timeline

• Aleksey_WMDE created this task.May 16 2017, 11:04 AM
• Aleksey_WMDE updated the task description. (Show Details)May 16 2017, 11:11 AM
gerritbot subscribed.May 18 2017, 8:23 PM

Change 354265 had a related patch set uploaded (by Aleksey Bekh-Ivanov (WMDE); owner: Aleksey Bekh-Ivanov (WMDE)):
[mediawiki/extensions/WikibaseLexeme@master] [WIP] Statement list on newly added form

https://gerrit.wikimedia.org/r/354265

gerritbot added a project: Patch-For-Review.May 18 2017, 8:23 PM
• Aleksey_WMDE mentioned this in rEWLE85d5684ed69b: [WIP] Statement list on newly added form.May 18 2017, 8:24 PM
• Aleksey_WMDE mentioned this in rEWLEb01cddeb064c: [WIP] Statement list on newly added form.May 18 2017, 8:29 PM
• Aleksey_WMDE claimed this task.May 18 2017, 8:33 PM
• Aleksey_WMDE moved this task from Proposed to Doing on the Wikidata-Former-Sprint-Board board.
• Aleksey_WMDE mentioned this in rEWLE8f77dd76202e: [WIP] Statement list on newly added form.May 18 2017, 8:36 PM
• Aleksey_WMDE mentioned this in rEWLE3a0f35c70b6b: [WIP] Statement list on newly added form.May 21 2017, 11:44 AM
• Aleksey_WMDE mentioned this in rEWLE04f8438a1241: [WIP] Statement list on newly added form.May 21 2017, 11:50 AM
gerritbot added a comment.May 21 2017, 12:09 PM

Change 354958 had a related patch set uploaded (by Aleksey Bekh-Ivanov (WMDE); owner: Aleksey Bekh-Ivanov (WMDE)):
[mediawiki/extensions/WikibaseLexeme@master] Lexeme serializer can serialize grammatical features

https://gerrit.wikimedia.org/r/354958

• Aleksey_WMDE mentioned this in rEWLE293f089d358e: Lexeme serializer can serialize grammatical features.May 21 2017, 12:11 PM
• Aleksey_WMDE mentioned this in rEWLEe60ece8ed5aa: [WIP] Statement list on newly added form.May 21 2017, 12:20 PM
gerritbot added a comment.May 21 2017, 12:29 PM

Change 354963 had a related patch set uploaded (by Aleksey Bekh-Ivanov (WMDE); owner: Aleksey Bekh-Ivanov (WMDE)):
[mediawiki/extensions/WikibaseLexeme@master] JS Lexeme deserializer can deserialize grammatical features

https://gerrit.wikimedia.org/r/354963

• Aleksey_WMDE mentioned this in rEWLE9136eff52b0a: JS Lexeme deserializer can deserialize grammatical features.May 21 2017, 12:31 PM
• Aleksey_WMDE mentioned this in rEWLE6bfc85d42d6a: Lexeme serializer can serialize grammatical features.May 21 2017, 12:33 PM
• Aleksey_WMDE mentioned this in rEWLEbcbfd035a833: JS Lexeme deserializer can deserialize grammatical features.May 21 2017, 12:35 PM
• Aleksey_WMDE mentioned this in rEWLEd85872120c47: [WIP] Statement list on newly added form.May 21 2017, 12:37 PM
gerritbot added a comment.May 21 2017, 12:56 PM

Change 354971 had a related patch set uploaded (by Aleksey Bekh-Ivanov (WMDE); owner: Aleksey Bekh-Ivanov (WMDE)):
[mediawiki/extensions/WikibaseLexeme@master] Make controller responsible for switching lexemeformview to edit mode

https://gerrit.wikimedia.org/r/354971

• Aleksey_WMDE mentioned this in rEWLEf1ec258d08ab: Make controller responsible for switching lexemeformview to edit mode.May 21 2017, 12:57 PM
• Aleksey_WMDE mentioned this in rEWLE482fc6e040a2: [WIP] Statement list on newly added form.May 21 2017, 7:41 PM
• Aleksey_WMDE mentioned this in rEWLEb3bc100c77f5: [WIP] Statement list on newly added form.May 21 2017, 7:55 PM
• Aleksey_WMDE mentioned this in rEWLE92bc78462bd2: Statement list on newly added form.May 22 2017, 9:57 AM
• Aleksey_WMDE moved this task from Doing to Review on the Wikidata-Former-Sprint-Board board.May 22 2017, 9:57 AM
• Aleksey_WMDE mentioned this in rEWLE7972fa15f8b4: Statement list on newly added form.May 22 2017, 10:32 AM
• Aleksey_WMDE mentioned this in rEWLE48d9ac57d03e: Statement list on newly added form.May 22 2017, 12:20 PM
gerritbot added a comment.May 23 2017, 5:10 PM

Change 354963 abandoned by Aleksey Bekh-Ivanov (WMDE):
JS Lexeme deserializer can deserialize grammatical features

Reason:
Abandoned in favor of Iecdf9e990ad8648a54b125a0bb4533674787d3e3

https://gerrit.wikimedia.org/r/354963

• Aleksey_WMDE mentioned this in rEWLE9154eae54048: Lexeme serializer can serialize grammatical features.May 24 2017, 11:08 AM
WMDE-leszek mentioned this in rEWLE0a2ea33e2b1f: Lexeme serializer can serialize grammatical features.May 24 2017, 1:53 PM
gerritbot added a comment.May 24 2017, 4:16 PM

Change 354958 merged by jenkins-bot:
[mediawiki/extensions/WikibaseLexeme@master] Lexeme serializer can serialize grammatical features

https://gerrit.wikimedia.org/r/354958

• Aleksey_WMDE mentioned this in rEWLE3ed840b05bd2: Make controller responsible for switching lexemeformview to edit mode.May 25 2017, 9:25 AM
• Aleksey_WMDE mentioned this in rEWLE494fac01e527: Make controller responsible for switching lexemeformview to edit mode.
• Aleksey_WMDE mentioned this in rEWLE533c0849b9af: Make controller responsible for switching lexemeformview to edit mode.May 25 2017, 9:28 AM
• Aleksey_WMDE mentioned this in rEWLEc54021d38320: Statement list on newly added form.May 25 2017, 9:40 AM
• Aleksey_WMDE mentioned this in rEWLE444166d8f4b0: Statement list on newly added form.May 25 2017, 10:04 AM
• Aleksey_WMDE mentioned this in rEWLE9dd5fef89ac6: Make controller responsible for switching lexemeformview to edit mode.May 25 2017, 6:07 PM
• Aleksey_WMDE mentioned this in rEWLEe7f0c7ddb3ac: Make controller responsible for switching lexemeformview to edit mode.
• Aleksey_WMDE mentioned this in rEWLEc4e92b1480b9: Statement list on newly added form.
• Aleksey_WMDE mentioned this in rEWLE91ecd9c99ef2: Statement list on newly added form.May 25 2017, 6:11 PM
• Aleksey_WMDE mentioned this in rEWLE1fff0ef2cd98: Statement list on newly added form.May 29 2017, 9:18 AM
• Aleksey_WMDE mentioned this in rEWLE3c9a13b5b7ad: Statement list on newly added form.May 29 2017, 9:21 AM
• Aleksey_WMDE mentioned this in rEWLEbfd0970d296e: Statement list on newly added form.
gerritbot added a comment.May 29 2017, 3:33 PM

Change 354971 merged by jenkins-bot:
[mediawiki/extensions/WikibaseLexeme@master] Make controller responsible for switching lexemeformview to edit mode

https://gerrit.wikimedia.org/r/354971

gerritbot added a comment.May 29 2017, 4:40 PM

Change 354265 merged by jenkins-bot:
[mediawiki/extensions/WikibaseLexeme@master] Statement list on newly added form

https://gerrit.wikimedia.org/r/354265

Lucas_Werkmeister_WMDE moved this task from Review to Doing on the Wikidata-Former-Sprint-Board board.May 31 2017, 10:01 AM
• Aleksey_WMDE moved this task from Doing to Review on the Wikidata-Former-Sprint-Board board.May 31 2017, 12:08 PM
Lucas_Werkmeister_WMDE moved this task from Review to Done on the Wikidata-Former-Sprint-Board board.Jun 1 2017, 10:03 AM
Lucas_Werkmeister_WMDE moved this task from Done to Doing on the Wikidata-Former-Sprint-Board board.
gerritbot added a comment.Jun 2 2017, 3:25 PM

Change 355648 had a related patch set uploaded (by Aleksey Bekh-Ivanov (WMDE); owner: Aleksey Bekh-Ivanov (WMDE)):
[mediawiki/extensions/WikibaseLexeme@master] Add browser test for new Form`s statement creation

https://gerrit.wikimedia.org/r/355648

• Aleksey_WMDE mentioned this in rEWLE7c8d38f2826b: Add browser test for new Form`s statement creation.Jun 2 2017, 3:25 PM
• Aleksey_WMDE moved this task from Doing to Review on the Wikidata-Former-Sprint-Board board.Jun 2 2017, 3:25 PM
WMDE-leszek moved this task from Review to Done on the Wikidata-Former-Sprint-Board board.Jun 7 2017, 8:31 AM

With the browser test added this should be done now, right?

Lydia_Pintscher closed this task as Resolved.Jun 7 2017, 9:00 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits