rockmfr wrote:

Special:Upload patch (option 1)

Going with option #1 as it is the easiest...

Attached:

Done in r36317.

I did it slightly different. Instead, I took the value of $this->mIgnoreWarning as a value for future warnings.

rockmfr wrote:

Actually, I don't think that will work. Because the rest of the code treats it as a checkbox, it is considered true if a value is submitted at all, even if it is just empty.

What about:

$uploadWarningBool = 0
if ( $this->mIgnoreWarnings ) $uploadWarningBool = 1;
...
...
Xml::hidden( 'wpIgnoreWarning', $uploadWarningBool ) . "\n" .

rockmfr wrote:

Nope, because it doesn't matter what the previous setting of mIgnoreWarnings was once you get to the warning page. At that point, it will be false all the time.

You're right, I was trying to overthink it. Done in r36318 by your original patch.