Page MenuHomePhabricator

"unreachable code after return statement" in function _flowBoardComponentLoadMoreFeatureRenderTopics
Open, Needs TriagePublic

Description

On https://fr.wikipedia.org/w/index.php?title=Wikip%C3%A9dia:Flow/Bac_%C3%A0_sable&debug=true

unreachable code after return statement @ flow-board-loadmore.js:483:3 @ function _flowBoardComponentLoadMoreFeatureRenderTopics

Concerned JS code:

// eslint-disable-next-line no-unreachable
if ( !topicsData.links.pagination.fwd && !topicsData.links.pagination.rev ) {
     return;
}

I do not know if it's important. I use Firefox 53.0.2.

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald Transcript
Framawiki updated the task description. (Show Details)

I'm getting this error on Firefox 58.0.1 on https://www.mediawiki.org/wiki/Help_talk:Extension:GlobalPreferences?debug=1

I don't know if it's related, but it doesn't let me edit the board's description (opens the editing box, but clicking in it does nothing).

I don't know if it's related, but it doesn't let me edit the board's description (opens the editing box, but clicking in it does nothing).

Probably not related. See T185205: Cannot create board description (but can edit an existing one)
Should be fixed in wmf.20 but that doesn't seem to be deployed anywhere.

Change 408992 abandoned by Aklapper:
[mediawiki/extensions/Flow@master] Fix "unreachable code after return statement" warning

Reason:
shrug

https://gerrit.wikimedia.org/r/408992