Page MenuHomePhabricator

DonationInterface needs to use the same data keys as the backend
Closed, ResolvedPublic4 Estimated Story Points

Description

SmashPig has been working with the normalized-for-queue key names, i.e. first_name instead of fname, gross instead of amount. Now that we want to use SmashPig for frontend logic as well, we shouldn't pollute it with the DonationInterface variants.

We've done this with zip->postal_code, and we can do it again.

This will also be a great reduction in confusion.

Note: we will also want to update the log parsing in the audit code to look for the correct keys.

Event Timeline

Ejegg triaged this task as High priority.May 19 2017, 10:35 PM
Ejegg updated the task description. (Show Details)
Ejegg set the point value for this task to 4.

Change 354606 had a related patch set uploaded (by Ejegg; owner: Ejegg):
[mediawiki/extensions/DonationInterface@master] Use normalized key for supplemental_address_1

https://gerrit.wikimedia.org/r/354606

Change 354610 had a related patch set uploaded (by Ejegg; owner: Ejegg):
[mediawiki/extensions/DonationInterface@master] Rename 'street' field to normalized 'street_address'

https://gerrit.wikimedia.org/r/354610

Change 354613 had a related patch set uploaded (by Ejegg; owner: Ejegg):
[wikimedia/fundraising/crm@master] Audit processors can read normalized fields in logs

https://gerrit.wikimedia.org/r/354613

Change 354606 merged by jenkins-bot:
[mediawiki/extensions/DonationInterface@master] Use normalized key for supplemental_address_1

https://gerrit.wikimedia.org/r/354606

Change 354610 merged by jenkins-bot:
[mediawiki/extensions/DonationInterface@master] Rename 'street' field to normalized 'street_address'

https://gerrit.wikimedia.org/r/354610

Change 355141 had a related patch set uploaded (by XenoRyet; owner: XenoRyet):
[mediawiki/extensions/DonationInterface@master] Rename 'fname' to normalized 'first_name'

https://gerrit.wikimedia.org/r/355141

Change 355141 merged by jenkins-bot:
[mediawiki/extensions/DonationInterface@master] Rename 'fname' to normalized 'first_name'

https://gerrit.wikimedia.org/r/355141

Change 355146 had a related patch set uploaded (by XenoRyet; owner: XenoRyet):
[mediawiki/extensions/DonationInterface@master] Rename 'lname' to normalized 'last_name'

https://gerrit.wikimedia.org/r/355146

Change 355146 merged by jenkins-bot:
[mediawiki/extensions/DonationInterface@master] Rename 'lname' to normalized 'last_name'

https://gerrit.wikimedia.org/r/355146

Change 355153 had a related patch set uploaded (by Ejegg; owner: Ejegg):
[mediawiki/extensions/DonationInterface@master] Rename currency_code to currency

https://gerrit.wikimedia.org/r/355153

Change 355167 had a related patch set uploaded (by Ejegg; owner: Ejegg):
[mediawiki/extensions/DonationInterface@master] Rename state field to match backend state_province

https://gerrit.wikimedia.org/r/355167

Change 355153 merged by jenkins-bot:
[mediawiki/extensions/DonationInterface@master] Rename currency_code to currency

https://gerrit.wikimedia.org/r/355153

Change 355167 merged by jenkins-bot:
[mediawiki/extensions/DonationInterface@master] Rename state field to match backend state_province

https://gerrit.wikimedia.org/r/355167

Change 355169 had a related patch set uploaded (by Ejegg; owner: Ejegg):
[mediawiki/extensions/DonationInterface@master] Rename amount to gross

https://gerrit.wikimedia.org/r/355169

Change 355173 had a related patch set uploaded (by Ejegg; owner: Ejegg):
[mediawiki/extensions/DonationInterface@master] Allow old keys in session values

https://gerrit.wikimedia.org/r/355173

Change 355169 merged by jenkins-bot:
[mediawiki/extensions/DonationInterface@master] Rename amount to gross

https://gerrit.wikimedia.org/r/355169

Change 355173 merged by jenkins-bot:
[mediawiki/extensions/DonationInterface@master] Allow old keys in session values

https://gerrit.wikimedia.org/r/355173

Change 354613 merged by jenkins-bot:
[wikimedia/fundraising/crm@master] Audit processors can read normalized fields in logs

https://gerrit.wikimedia.org/r/354613

Change 355488 had a related patch set uploaded (by Ejegg; owner: Ejegg):
[wikimedia/fundraising/crm@master] Payments-init consumer can handle 'currency' message field.

https://gerrit.wikimedia.org/r/355488

Change 355488 merged by jenkins-bot:
[wikimedia/fundraising/crm@master] Payments-init consumer can handle 'currency' message field.

https://gerrit.wikimedia.org/r/355488

Change 355728 had a related patch set uploaded (by Ejegg; owner: Ejegg):
[mediawiki/extensions/DonationInterface@wmf/1.30.0-wmf.2] Allow old keys in session values

https://gerrit.wikimedia.org/r/355728

Change 355728 merged by jenkins-bot:
[mediawiki/extensions/DonationInterface@wmf/1.30.0-wmf.2] Allow old keys in session values

https://gerrit.wikimedia.org/r/355728