Page MenuHomePhabricator
Create Task
Maniphest T165818

DonationInterface needs to use the same data keys as the backend
Closed, ResolvedPublic4 Estimated Story Points
Actions

Description

SmashPig has been working with the normalized-for-queue key names, i.e. first_name instead of fname, gross instead of amount. Now that we want to use SmashPig for frontend logic as well, we shouldn't pollute it with the DonationInterface variants.

We've done this with zip->postal_code, and we can do it again.

This will also be a great reduction in confusion.

Note: we will also want to update the log parsing in the audit code to look for the correct keys.

Details

Related Changes in Gerrit:
Show related patches Customize query in gerrit

Event Timeline

Ejegg created this task.May 19 2017, 10:33 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMay 19 2017, 10:33 PM
Ejegg triaged this task as High priority.May 19 2017, 10:35 PM
Ejegg updated the task description. (Show Details)
Ejegg set the point value for this task to 4.
gerritbot subscribed.May 19 2017, 11:17 PM

Change 354606 had a related patch set uploaded (by Ejegg; owner: Ejegg):
[mediawiki/extensions/DonationInterface@master] Use normalized key for supplemental_address_1

https://gerrit.wikimedia.org/r/354606

gerritbot added a project: Patch-For-Review.May 19 2017, 11:17 PM

Change 354610 had a related patch set uploaded (by Ejegg; owner: Ejegg):
[mediawiki/extensions/DonationInterface@master] Rename 'street' field to normalized 'street_address'

https://gerrit.wikimedia.org/r/354610

gerritbot added a comment.May 19 2017, 11:55 PM

Change 354613 had a related patch set uploaded (by Ejegg; owner: Ejegg):
[wikimedia/fundraising/crm@master] Audit processors can read normalized fields in logs

https://gerrit.wikimedia.org/r/354613

gerritbot added a comment.May 22 2017, 5:23 PM

Change 354606 merged by jenkins-bot:
[mediawiki/extensions/DonationInterface@master] Use normalized key for supplemental_address_1

https://gerrit.wikimedia.org/r/354606

gerritbot added a comment.May 22 2017, 5:25 PM

Change 354610 merged by jenkins-bot:
[mediawiki/extensions/DonationInterface@master] Rename 'street' field to normalized 'street_address'

https://gerrit.wikimedia.org/r/354610

ReleaseTaggerBot added a project: MW-1.30-release-notes (WMF-deploy-2017-05-23_(1.30.0-wmf.2)).May 22 2017, 6:00 PM
gerritbot added a comment.May 22 2017, 6:10 PM

Change 355141 had a related patch set uploaded (by XenoRyet; owner: XenoRyet):
[mediawiki/extensions/DonationInterface@master] Rename 'fname' to normalized 'first_name'

https://gerrit.wikimedia.org/r/355141

gerritbot added a comment.May 22 2017, 6:35 PM

Change 355141 merged by jenkins-bot:
[mediawiki/extensions/DonationInterface@master] Rename 'fname' to normalized 'first_name'

https://gerrit.wikimedia.org/r/355141

gerritbot added a comment.May 22 2017, 6:39 PM

Change 355146 had a related patch set uploaded (by XenoRyet; owner: XenoRyet):
[mediawiki/extensions/DonationInterface@master] Rename 'lname' to normalized 'last_name'

https://gerrit.wikimedia.org/r/355146

gerritbot added a comment.May 22 2017, 6:59 PM

Change 355146 merged by jenkins-bot:
[mediawiki/extensions/DonationInterface@master] Rename 'lname' to normalized 'last_name'

https://gerrit.wikimedia.org/r/355146

gerritbot added a comment.May 22 2017, 7:24 PM

Change 355153 had a related patch set uploaded (by Ejegg; owner: Ejegg):
[mediawiki/extensions/DonationInterface@master] Rename currency_code to currency

https://gerrit.wikimedia.org/r/355153

gerritbot added a comment.May 22 2017, 10:05 PM

Change 355167 had a related patch set uploaded (by Ejegg; owner: Ejegg):
[mediawiki/extensions/DonationInterface@master] Rename state field to match backend state_province

https://gerrit.wikimedia.org/r/355167

gerritbot added a comment.May 22 2017, 10:06 PM

Change 355153 merged by jenkins-bot:
[mediawiki/extensions/DonationInterface@master] Rename currency_code to currency

https://gerrit.wikimedia.org/r/355153

gerritbot added a comment.May 22 2017, 10:28 PM

Change 355167 merged by jenkins-bot:
[mediawiki/extensions/DonationInterface@master] Rename state field to match backend state_province

https://gerrit.wikimedia.org/r/355167

gerritbot added a comment.May 22 2017, 11:21 PM

Change 355169 had a related patch set uploaded (by Ejegg; owner: Ejegg):
[mediawiki/extensions/DonationInterface@master] Rename amount to gross

https://gerrit.wikimedia.org/r/355169

gerritbot added a comment.May 22 2017, 11:42 PM

Change 355173 had a related patch set uploaded (by Ejegg; owner: Ejegg):
[mediawiki/extensions/DonationInterface@master] Allow old keys in session values

https://gerrit.wikimedia.org/r/355173

gerritbot added a comment.May 22 2017, 11:58 PM

Change 355169 merged by jenkins-bot:
[mediawiki/extensions/DonationInterface@master] Rename amount to gross

https://gerrit.wikimedia.org/r/355169

Ejegg claimed this task.May 23 2017, 6:05 PM
Ejegg added projects: Unplanned-Sprint-Work, Fundraising Sprint Judgement Suspenders.
Ejegg moved this task from Backlog to Pending Deployment on the Fundraising Sprint Judgement Suspenders board.
gerritbot added a comment.May 23 2017, 7:04 PM

Change 355173 merged by jenkins-bot:
[mediawiki/extensions/DonationInterface@master] Allow old keys in session values

https://gerrit.wikimedia.org/r/355173

Ejegg moved this task from Triage to Completed in Q4 2016-17 on the Fundraising-Backlog board.May 23 2017, 7:46 PM
ReleaseTaggerBot edited projects, added MW-1.30-release-notes (WMF-deploy-2017-05-30_(1.30.0-wmf.3)); removed MW-1.30-release-notes (WMF-deploy-2017-05-23_(1.30.0-wmf.2)).May 23 2017, 8:00 PM
gerritbot added a comment.May 23 2017, 10:25 PM

Change 354613 merged by jenkins-bot:
[wikimedia/fundraising/crm@master] Audit processors can read normalized fields in logs

https://gerrit.wikimedia.org/r/354613

gerritbot added a comment.May 24 2017, 8:25 PM

Change 355488 had a related patch set uploaded (by Ejegg; owner: Ejegg):
[wikimedia/fundraising/crm@master] Payments-init consumer can handle 'currency' message field.

https://gerrit.wikimedia.org/r/355488

• ggellerman added a project: Fundraising Sprint Kickstopper.May 24 2017, 10:38 PM
• ggellerman moved this task from Backlog to Doing on the Fundraising Sprint Kickstopper board.May 24 2017, 10:50 PM
Ejegg moved this task from Doing to Pending Deployment on the Fundraising Sprint Kickstopper board.May 24 2017, 10:54 PM
gerritbot added a comment.May 24 2017, 11:35 PM

Change 355488 merged by jenkins-bot:
[wikimedia/fundraising/crm@master] Payments-init consumer can handle 'currency' message field.

https://gerrit.wikimedia.org/r/355488

gerritbot added a comment.May 25 2017, 11:23 PM

Change 355728 had a related patch set uploaded (by Ejegg; owner: Ejegg):
[mediawiki/extensions/DonationInterface@wmf/1.30.0-wmf.2] Allow old keys in session values

https://gerrit.wikimedia.org/r/355728

gerritbot added a comment.May 25 2017, 11:27 PM

Change 355728 merged by jenkins-bot:
[mediawiki/extensions/DonationInterface@wmf/1.30.0-wmf.2] Allow old keys in session values

https://gerrit.wikimedia.org/r/355728

ReleaseTaggerBot edited projects, added MW-1.30-release-notes (WMF-deploy-2017-05-23_(1.30.0-wmf.2)); removed MW-1.30-release-notes (WMF-deploy-2017-05-30_(1.30.0-wmf.3)).May 26 2017, 12:00 AM
Ejegg moved this task from Pending Deployment to Done on the Fundraising Sprint Kickstopper board.May 31 2017, 9:14 PM
Ejegg closed this task as Resolved.Jun 2 2017, 10:49 PM
• DStrine removed a project: Unplanned-Sprint-Work.Oct 18 2017, 5:20 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits