Page MenuHomePhabricator

ApiSandbox stalls on HTTP errors
Closed, ResolvedPublic

Description

Since rMWbf69459d5011: Upgrade to jQuery v3, ApiSandbox seems to stall out when an API request results in an HTTP error (e.g. due to a PHP fatal error). Before that revision, it displayed the 'apisandbox-results-error' message in this situation.

Apparently the jQuery 3 changes to Deferred behavior caused it to be impossible to have a then() filter return this (or anything else) in order to avoid replacing the existing promise that's being resolved or rejected.

Event Timeline

Anomie created this task.May 20 2017, 10:26 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMay 20 2017, 10:26 AM

Change 354654 had a related patch set uploaded (by Anomie; owner: Anomie):
[mediawiki/core@master] ApiSandbox: Fix HTTP error handling

https://gerrit.wikimedia.org/r/354654

Anomie moved this task from Unsorted to Needs Review on the MediaWiki-API board.May 20 2017, 10:28 AM

Change 354654 merged by jenkins-bot:
[mediawiki/core@master] ApiSandbox: Fix HTTP error handling

https://gerrit.wikimedia.org/r/354654

Anomie closed this task as Resolved.May 20 2017, 7:37 PM
Aklapper removed a subscriber: Anomie.Oct 16 2020, 5:42 PM