Page MenuHomePhabricator

Reduce max_retries from 25 to 15
Closed, ResolvedPublic

Description

The default setting for retrying are:

  • start timer: 5s
  • max timer: 120s
  • number of retries: 25

This leads to a total waiting time of ~43 minutes, which is a bit high, especially for newcomers, which are prone to configuration mistakes. I would suggest reducing the number of retries from 25 to 15, for a reduction of 20 minutes in total retry timer. Users who run autonomous bots can customize this in their user-config or directly in the script.

Event Timeline

I agree with you, 15 seems to me sufficient.

Framawiki triaged this task as Medium priority.May 20 2017, 3:53 PM

Change 354727 had a related patch set uploaded (by Framawiki; owner: Framawiki):
[pywikibot/core@master] Reduce default max_retries from 25 to 15

https://gerrit.wikimedia.org/r/354727

Haha, did a patch myself, but gerritbot did not catch it: https://gerrit.wikimedia.org/r/#/c/354714/

Change 354714 had a related patch set uploaded (by Strainu; owner: Strainu):
[pywikibot/core@master] Config2: limit the number of retries to 15

https://gerrit.wikimedia.org/r/354714

Change 354714 merged by jenkins-bot:
[pywikibot/core@master] Config2: limit the number of retries to 15

https://gerrit.wikimedia.org/r/354714

Framawiki reassigned this task from Framawiki to Strainu.

... please next time claim the task if you plan to work on it

@Framawiki: I had to decide which patchset to review; I took the older one and overlooked that you already claimed this task. I am very sorry.

Change 354727 abandoned by Framawiki:
Reduce default max_retries from 25 to 15

Reason:
Duplicate

https://gerrit.wikimedia.org/r/354727

No problem. The key is that it is done :)