Vertical page previews missing last line
Closed, ResolvedPublic2 Estimated Story Points
Actions

Assigned To

Authored By

	ovasileva
	May 21 2017, 11:46 AM

Description

Vertical page previews are one line shorter than their horizontal counterparts:

Screen Shot 2017-05-21 at 1.46.14 PM.png (439×348 px, 142 KB)

Screen Shot 2017-05-21 at 1.46.04 PM.png (316×493 px, 156 KB)

Acceptance criteria:

Add one more line of text to vertical previews (Nelson Piquet) so that the gap between the last line and the cog is reduced.

Steps to reproduce:

Go to https://en.wikipedia.org/wiki/Zenobia as a logged-in user with page preview on
Hover over "Syria"
The last line of text is not available - there is one line of white space between the end of the extract and the settings cog

Developer notes

Inspecting the api request there is more text available so we should be able to increase the height of the preview text with css.

Details

	Subject	Repo	Branch	Lines +/-
	Increase line number count of preview with tall image	mediawiki/extensions/Popups	master	+1 -1
	Make vertical preview show 7 lines	mediawiki/extensions/Popups	master	+1 -1

Customize query in gerrit

Related Objects

Mentioned Here: T165974: Page previews horizontal gradient overlaps previous line

Event Timeline

ovasileva created this task.May 21 2017, 11:46 AM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMay 21 2017, 11:46 AM

ovasileva triaged this task as High priority.May 21 2017, 11:47 AM

ovasileva moved this task from Incoming to Upcoming on the Web-Team-Backlog board.

ovasileva updated the task description. (Show Details)May 23 2017, 4:37 PM

Jdlrobson updated the task description. (Show Details)May 23 2017, 4:38 PM

Further clarification:

Vertical previews are previews with horizontal layout
What is missing:

ovasileva set the point value for this task to 2.May 23 2017, 4:40 PM

ovasileva added a project: Readers-Web-Kanbanana-Board-Old.May 31 2017, 11:56 AM

Jdlrobson moved this task from Upcoming to 2016-17 Q4 on the Web-Team-Backlog board.May 31 2017, 4:53 PM

• NHarateh_WMF moved this task from To Do to Needs Design Review on the Readers-Web-Kanbanana-Board-Old board.May 31 2017, 5:20 PM

This is closely related to T165974, so I'm going to work on both task together.

• bmansurov claimed this task.May 31 2017, 7:27 PM

Change 356465 had a related patch set uploaded (by Bmansurov; owner: Bmansurov):
[mediawiki/extensions/Popups@master] Make vertical preview show 7 lines

https://gerrit.wikimedia.org/r/356465

gerritbot added a project: Patch-For-Review.May 31 2017, 8:19 PM

• bmansurov moved this task from Doing to Needs Code Review on the Readers-Web-Kanbanana-Board-Old board.May 31 2017, 8:19 PM

I'm finding myself unsure if I've understood this task correctly. Reviewing Baha's patch I see an additional line:

Before:

Screen Shot 2017-06-01 at 1.21.07 PM.png (382×494 px, 149 KB)

After:

Screen Shot 2017-06-01 at 1.19.15 PM.png (399×526 px, 157 KB)

However, there is still more text that is possible to show.. I thought the goal was to take up as much vertical whitespace as possible?
e.g.

Screen Shot 2017-06-01 at 1.24.30 PM.png (371×526 px, 164 KB)

Can someone clarify? @ovasileva

@Jdlrobson - not quite, the goal is as in the task descrption - adding one more line to vertical previews. We want vertical and horizontal previews to have the same of amount of space between the end of the text and the setting cog.

• bmansurov moved this task from Needs More Work to Needs Code Review on the Readers-Web-Kanbanana-Board-Old board.Jun 6 2017, 1:56 PM

Change 356465 merged by jenkins-bot:
[mediawiki/extensions/Popups@master] Make vertical preview show 7 lines

https://gerrit.wikimedia.org/r/356465

ReleaseTaggerBot added a project: MW-1.30-release-notes (WMF-deploy-2017-06-06_(1.30.0-wmf.4)).Jun 6 2017, 4:00 PM

Jdlrobson moved this task from Needs Code Review to Needs QA on the Readers-Web-Kanbanana-Board-Old board.Jun 6 2017, 4:04 PM

Jdlrobson removed a project: Patch-For-Review.

• bmansurov removed • bmansurov as the assignee of this task.Jun 6 2017, 4:39 PM

Over to you @ABorbaWMF. Find a couple of articles with long previews on the Beta Cluster and marvel at the additional line of text that you can see!

Tested on the Dog article on Beta. I purged the page. I am still seeing page previews with 7 lines instead of 8 line. @phuedx, do you think I need a taller image? I tested against the Canidae and Color Blindness articles.

@ABorbaWMF, do you have any kind of zoom on in your browser, @bmansurov mentioned that it might not display correctly due to zoom levels

Also, the code is created to have 7 lines. Did we want 8? If we look at the screenshot from the description, there are 6 lines. So we increased it to 7.

@bmansurov - I'm a bit confused, I think there was some confusion in the task description. In the description, the vertical extract has 8 lines and we wanted to increase it by one line to 9. In @ABorbaWMF's screenshot, we have 7.

Per T165978#3347468.

@ovasileva, OK, let's clarify it. So the "WannaCry" screenshot (the first one in the description) has 6 lines, correct? Which screenshot has 8 lines again?

@bmansurov: in the description, the Nelson Piquet screenshot has 8 lines, we want it to have 9 lines. By "one line shorter" I meant that the distance between the end of the text and the settings cog in the vertical previews (Nelson Piquet) is two lines, while in the horizontal previews (WannaCry) it is one line

@ovasileva thanks for clarifying. I'll update the A/C to include what you meant.

• bmansurov updated the task description. (Show Details)Jun 14 2017, 1:48 PM

• bmansurov claimed this task.Jun 14 2017, 2:00 PM

• bmansurov moved this task from Needs More Work to Doing on the Readers-Web-Kanbanana-Board-Old board.

Change 358970 had a related patch set uploaded (by Bmansurov; owner: Bmansurov):
[mediawiki/extensions/Popups@master] Increase line number count of preview with tall image

https://gerrit.wikimedia.org/r/358970

gerritbot added a project: Patch-For-Review.Jun 14 2017, 2:24 PM

• bmansurov moved this task from Doing to Needs Code Review on the Readers-Web-Kanbanana-Board-Old board.Jun 14 2017, 2:24 PM

Jdlrobson moved this task from Needs Code Review to Needs QA on the Readers-Web-Kanbanana-Board-Old board.Jun 14 2017, 6:41 PM

• bmansurov removed • bmansurov as the assignee of this task.Jun 14 2017, 6:43 PM

Change 358970 merged by jenkins-bot:
[mediawiki/extensions/Popups@master] Increase line number count of preview with tall image

https://gerrit.wikimedia.org/r/358970

Jdlrobson removed a project: Patch-For-Review.Jun 14 2017, 6:58 PM

ReleaseTaggerBot edited projects, added MW-1.30-release-notes (WMF-deploy-2017-06-20_(1.30.0-wmf.6)); removed MW-1.30-release-notes (WMF-deploy-2017-06-06_(1.30.0-wmf.4)).Jun 14 2017, 7:00 PM

Tested on the [[ Tested on the Dog article on Beta. I purged the page. | Dog ]] article on Beta. I purged the page. Tried a number of different browsers and systems. Lots of lines now :)

Please sign off :)

looks good!

	F8247085: Screen Shot 2017-06-01 at 1.21.07 PM.png
	Jun 1 2017, 8:25 PM

	F8247200: Screen Shot 2017-06-01 at 1.24.30 PM.png
	Jun 1 2017, 8:25 PM

	F8247086: Screen Shot 2017-06-01 at 1.19.15 PM.png
	Jun 1 2017, 8:25 PM

	F8169229: Screen Shot 2017-05-23 at 6.35.33 PM.png
	May 23 2017, 4:39 PM

	F8146373: Screen Shot 2017-05-21 at 1.46.04 PM.png
	May 21 2017, 11:46 AM

	F8146371: Screen Shot 2017-05-21 at 1.46.14 PM.png
	May 21 2017, 11:46 AM

	F8419341: image.png
	Jun 8 2017, 11:45 PM

	F8419344: image.png
	Jun 8 2017, 11:45 PM

Vertical page previews missing last lineClosed, ResolvedPublic2 Estimated Story PointsActions