Missing mediawiki::user in some way?

The mwdeploy user requires (or required at some point) to have the same UID on all the deployment target. To achieve that, we went to add the user in LDAP:

dn: uid=mwdeploy,ou=people,dc=wikimedia,dc=org
	uid: mwdeploy
	objectClass: person
	objectClass: inetorgperson
	objectClass: organizationalPerson
	objectClass: ldappublickey
	objectClass: shadowaccount
	objectClass: posixaccount
	objectClass: top
	loginShell: /bin/bash
	uidNumber: 603
	gidNumber: 603
	sn: mwdeploy
	homeDirectory: /home/mwdeploy
	cn: mwdeploy

The puppet resource User[mwdeploy] defines the home directory as /var/lib/scap, since that mismatch what is in LDAP puppet tries to user mod it to fix it and fail.

The root cause would be whatever change changed the homedir in puppet, and a fix would probably be to update mwdeploy home dir in LDAP ?

Apparently that comes from the cherry picked patch: Add 3d2png deploy repo to image scalers https://gerrit.wikimedia.org/r/#/c/345377/

Maybe due to scap::target and $manage_user.

@hashar: Nothing wrong with the patch in gerrit, as far as I can see. I don't know where puppet is trying to change the homedir but I will try to track that down. I also don't know how to edit the user in ldap but that might be the right thing to do.

So the user's home directory is set in scap::target. So we either fix it in ldap or remove that line from scap::target (I think the former as scap::target is correct for production)

Change 365891 had a related patch set uploaded (by 20after4; owner: 20after4):
[operations/puppet@production] Change $deploy_user home directory to /var/lib/${deploy_user}

https://gerrit.wikimedia.org/r/365891

cherry picked https://gerrit.wikimedia.org/r/#/c/365891/ on beta puppetmaster. This works around the problem and may actually be the more correct solution.

Change 365891 merged by Dzahn:
[operations/puppet@production] Change $deploy_user home directory to /var/lib/${deploy_user}

https://gerrit.wikimedia.org/r/365891