Page MenuHomePhabricator

Media Viewer cogwheel-preferences stopped working
Closed, ResolvedPublic


The Media Viewer cogwheel-disable option has stopped working for me recently. I have tested using Firefox and Chrome, and tested across multiple language wikis.
Expected Results:

  1. Using Desktop, go to a wiki where I have not yet set a local Media-Viewer opt-out.
  2. Go to a random article and click on an image.
  3. Media Viewer pops up. (Experience expected annoyance that this intrusive vampire rises from the dead every time I visit a new wiki.)
  4. Click the Cogwheel and click to disable Media Viewer. (Yeay, one more wiki where this vampire should stay dead.)
  5. The next image I click should bring up the file page.

Step 4 plays out normally with no visible problem, but it doesn't actually work. Checking the user preferences page shows that Media Viewer is still enabled. At step 5 Media Viewer is continuing to claim ownership of images.

Click preferences link. Click appearance tab. Scroll down and manually remove the check mark from the Enable Media Viewer box. Click save. Repeat this workaround on each of hundreds of wikis.

Also please note related task T144571. Disable is broken-with-a-workaround on desktop, but Opt-Out completely fails on Mobile.

Event Timeline

  1. I use Chromium 57.
  2. Make sure that has "Enable Media Viewer" enabled.
  3. is set to defaults.
  4. I go to
  5. Featured article today is "Vampire" and links to the image
  6. I click the thumbnail image
  7. MediaViewer opens
  8. I click the cog in the upper right corner.
  9. I click "Disable MediaViewer".
  10. It says "You have disabled Media Viewer. Next time you click on a thumbnail on Wikipedia, you will directly view all file details."
  11. I press "Escape" on my keyboard to close the MediaViewer.
  12. I click the Bela_lugosi_dracula.jpg thumbnail image on again.
  13. I end up on and MediaViewer does not start.
  14. Under , "Enable MediaViewer" is still enabled. Which looks like a bug.

Hence cannot completely reproduce the problem.

Side note: This bug report is helpful technical input. It would be even more welcome if you just called software by the actual name of the software.

[Unrelated to Multimedia team hence removing tag.]

Change 384693 had a related patch set uploaded (by Matthias Mullie; owner: Matthias Mullie):
[mediawiki/extensions/MultimediaViewer@master] Use User::getDefaultOptions instead of wgDefaultUserOptions

Change 384693 merged by jenkins-bot:
[mediawiki/extensions/MultimediaViewer@master] Use User::getDefaultOptions instead of wgDefaultUserOptions

ABorbaWMF added a subscriber: ABorbaWMF.

Tried this on Windows and Mac using Chrome, Safari, IE, Edge, and Firefox. I was not able to reproduce the originally described issue. Looks fixed.