Page MenuHomePhabricator
Create Task
Maniphest T166134

"Uncaught Error: Inserted data is trying to close the root node (at index 0)" appears after closing the dialog for Graph and pressing return
Closed, ResolvedPublic8 Estimated Story Points
Actions

Description

Steps to reproduce:

  1. Open VE
  2. Open the Graph insert dialog
  3. Click "Cancel" to close the dialog
  4. Observe that, the cursor has now moved to the end of the previous line
  5. Press return to go to the next line

The following error appears in the console:
Uncaught Error: Inserted data is trying to close the root node (at index 0)

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
Update VE core submodule to master (0ec5fe55f)mediawiki/extensions/VisualEditormaster+1 -1
ui.MWGraphDialog: update dialog fragment after popping stagingmediawiki/extensions/Graphmaster+1 -0
Surface: reset selection when popping stagingVisualEditor/VisualEditormaster+1 -1
Customize query in gerrit

Related Objects

Event Timeline

Ryasmeen created this task.May 23 2017, 2:01 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMay 23 2017, 2:01 PM
Jdforrester-WMF triaged this task as High priority.May 30 2017, 7:22 PM
Jdforrester-WMF moved this task from To Triage to Blocked on the VisualEditor board.
Jdforrester-WMF added a project: MediaWiki-extensions-Graph.
gerritbot subscribed.Sep 20 2017, 11:01 PM

Change 379435 had a related patch set uploaded (by DLynch; owner: DLynch):
[VisualEditor/VisualEditor@master] Surface: reset selection when popping staging

https://gerrit.wikimedia.org/r/379435

gerritbot added a project: Patch-For-Review.Sep 20 2017, 11:01 PM
gerritbot added a comment.Sep 20 2017, 11:05 PM

Change 379437 had a related patch set uploaded (by DLynch; owner: DLynch):
[mediawiki/extensions/Graph@master] ui.MWGraphDialog: update dialog fragment after popping staging

https://gerrit.wikimedia.org/r/379437

gerritbot added a comment.Sep 21 2017, 3:24 PM

Change 379435 merged by jenkins-bot:
[VisualEditor/VisualEditor@master] Surface: reset selection when popping staging

https://gerrit.wikimedia.org/r/379435

gerritbot added a comment.Sep 21 2017, 4:00 PM

Change 379557 had a related patch set uploaded (by DLynch; owner: DLynch):
[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (bd5da1725)

https://gerrit.wikimedia.org/r/379557

gerritbot added a comment.Sep 21 2017, 4:19 PM

Change 379437 merged by jenkins-bot:
[mediawiki/extensions/Graph@master] ui.MWGraphDialog: update dialog fragment after popping staging

https://gerrit.wikimedia.org/r/379437

ReleaseTaggerBot added a project: MW-1.31-release-notes (WMF-deploy-2017-09-26 (1.31.0-wmf.1)).Sep 21 2017, 5:00 PM
Jdforrester-WMF closed this task as Resolved.Sep 25 2017, 3:09 PM
Jdforrester-WMF assigned this task to DLynch.
Jdforrester-WMF set the point value for this task to 8.
Restricted Application added a project: User-Ryasmeen. · View Herald TranscriptSep 25 2017, 3:09 PM
gerritbot added a comment.Sep 25 2017, 3:16 PM

Change 379557 merged by jenkins-bot:
[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (0ec5fe55f)

https://gerrit.wikimedia.org/r/379557

Ryasmeen edited projects, added Verified; removed Patch-For-Review.Sep 25 2017, 6:07 PM
Ryasmeen added a project: Verified-in-Phase0.Sep 28 2017, 5:12 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits