Page MenuHomePhabricator
Create Task
Maniphest T166155

Wrong message displayed when trying to search while offline
Closed, ResolvedPublic1 Estimated Story Points
Actions

Description

While trying to search when the device is offline using the search icon displayed while reading an article, a wrong error message is displayed.

Steps to reproduce

  1. Enable flight mode
  2. Open the Main Page (probably by opening a new tab)
  3. Tap the search icon
  4. Type something

Expected results
"Cannot connect to internet" message is displayed.

Actual results
"Article cannot be loaded while offline" message is displayed.

Screen shot

Screenshot_2017-05-23-08-15-47.png (960×540 px, 45 KB)

Environments observed
App version : 2.5.195-alpha-2017-05-22
Android version : 5.1.1
Device vendor : Samsung
Device model : Galaxy J2 (SM-J200G)

Details

SubjectRepoBranchLines +/-
Show correct error msg when searching with no connection in PageActivityapps/android/wikipediamaster+36 -12
Customize query in gerrit

Event Timeline

Kaartic created this task.May 23 2017, 5:03 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMay 23 2017, 5:03 PM
• NHarateh_WMF added a project: Android-app-Bugs.May 24 2017, 3:26 PM
• NHarateh_WMF set the point value for this task to 1.
• NHarateh_WMF moved this task from Needs Triage to Bug Backlog on the Wikipedia-Android-App-Backlog board.
gerritbot subscribed.May 24 2017, 6:44 PM

Change 355473 had a related patch set uploaded (by Mholloway; owner: Mholloway):
[apps/android/wikipedia@master] Show correct error msg when searching with no connection in PageActivity

https://gerrit.wikimedia.org/r/355473

gerritbot added a project: Patch-For-Review.May 24 2017, 6:44 PM
• Mholloway claimed this task.May 24 2017, 6:45 PM
• Mholloway edited projects, added Wikipedia-Android-App-Backlog (Android-app-release-v2.6.19x-Bermuda🌴); removed Wikipedia-Android-App-Backlog.
• Mholloway moved this task from To Do to Code Review on the Wikipedia-Android-App-Backlog (Android-app-release-v2.6.19x-Bermuda🌴) board.
gerritbot added a comment.May 24 2017, 9:53 PM

Change 355473 merged by jenkins-bot:
[apps/android/wikipedia@master] Show correct error msg when searching with no connection in PageActivity

https://gerrit.wikimedia.org/r/355473

• Mholloway moved this task from Code Review to QA Signoff on the Wikipedia-Android-App-Backlog (Android-app-release-v2.6.19x-Bermuda🌴) board.May 24 2017, 9:58 PM
Nicholas.tsg subscribed.May 29 2017, 11:09 PM

Tested on Samsung-SM-JI20A Galaxy Express 3 (Android 6.0.1) and App version 2.5.195-alpha-2017-05-26. This is fixed, according to the below screencap "Cannot connect to internet" message is displayed in flight mode.

T166155.png (800×480 px, 43 KB)

• Mholloway moved this task from QA Signoff to Ready for Signoff on the Wikipedia-Android-App-Backlog (Android-app-release-v2.6.19x-Bermuda🌴) board.May 30 2017, 4:48 PM

This is ready for signoff if I'm not mistaken.

Dbrant moved this task from Ready for Signoff to Done on the Wikipedia-Android-App-Backlog (Android-app-release-v2.6.19x-Bermuda🌴) board.May 31 2017, 7:17 PM
Dbrant closed this task as Resolved.Jun 13 2017, 3:22 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL