Invalid DB key being added to categorylinks table on zhwikibooks
Open, Needs TriagePublic
Actions

Assigned To

None

Authored By

	TTO
	May 24 2017, 6:09 AM

Description

I created https://zh.wikibooks.org/wiki/User:This,_that_and_the_other/test (page id 23795) with the text [[Category:Blender 3D︰從入門到精通|插图集 ]] and a brand new invalid categorylinks row got added:

*** Looking for invalid cl_to entries in categorylinks...
*** Number of invalid rows: 4
   cl_from |  ns | dbkey
     15789 |  14 | Blender 3D︰从入门到精通
     15790 |  14 | Blender 3D︰从入门到精通
     15792 |  14 | Blender 3D︰从入门到精通
     23795 |  14 | Blender 3D︰从入门到精通     <<<<<< this one is new
*** Run with --fix to clean up these rows

This works fine on my local test wiki (in English). LinksUpdate.php has a call to $wgContLang->findVariantLink( $name, $nt, true ); which looks suspicious to me, and would explain why it works locally but fails on zhwikibooks.

Related Objects

Mentioned In: T99736: Special:Categories on some wikis errors out with "Exception encountered, of type "Wikimedia\Assert\ParameterAssertionException"

Event Timeline

TTO created this task.May 24 2017, 6:09 AM

Restricted Application added subscribers: Stang, Aklapper. · View Herald TranscriptMay 24 2017, 6:09 AM

TTO mentioned this in T99736: Special:Categories on some wikis errors out with "Exception encountered, of type "Wikimedia\Assert\ParameterAssertionException".May 24 2017, 6:10 AM

Ankry subscribed.May 24 2017, 7:00 AM

I agree, the call to $wgContLang->findVariantLink( $name, $nt, true ); looks suspicious.

It looks like LinksUpdate::getCategoryInsertions() assumes that ParserOutput::getCategories() returns an array with keys being title dbkeys, which at least in core and deployed extensions is true (it all depends on what gets passed to ParserOutput::addCategory()). But when $wgContLang->findVariantLink( $name, $nt, true ); does a variant conversion it populates $name with the title display text (->getText()) rather than the dbkey.

The thing to do is probably to 'cl_to' => $nt ? $nt->getDBkey() : $name instead of always using $name, or maybe skip the insertion entirely if $nt isn't a Title.

Liuxinyu970226 added a project: Chinese-Sites.May 25 2017, 5:48 AM

Liuxinyu970226 subscribed.

Shizhao moved this task from Backlog to MediaWiki core on the Chinese-Sites board.Jul 6 2020, 1:18 AM

Aklapper removed a subscriber: Anomie.Oct 16 2020, 5:01 PM

Winston_Sung moved this task from Untriaged to Script & term conversion on the I18n board.Aug 9 2023, 2:40 PM

Invalid DB key being added to categorylinks table on zhwikibooksOpen, Needs TriagePublicActions

Description

Related Objects

Event Timeline

Invalid DB key being added to categorylinks table on zhwikibooks
Open, Needs TriagePublic
Actions