Page MenuHomePhabricator
Create Task
Maniphest T166254

[Regression pre-wmf.3] VEditing fails at test wikivoyage wiki (Cannot read property 'hasOwnProperty' of undefined)
Closed, ResolvedPublic1 Estimated Story Points
Actions

Description

When I try and save a VEdit (while logged out), the console screams at me:

VM93:1325 Uncaught TypeError: Cannot read property 'hasOwnProperty' of undefined
    at VeInitMwDesktopArticleTarget.ve.init.mw.DesktopArticleTarget.saveComplete (eval at <anonymous> (https://en.wikivoyage.beta.wmflabs.org/w/load.php?debug=false&lang=en&modul…i%7Cmediawiki.legacy.wikibits&only=scripts&skin=vector&version=0r0nkm9:1:1), <anonymous>:1325:818)
    at VeInitMwDesktopArticleTarget.ve.init.mw.ArticleTarget.saveSuccess (eval at <anonymous> (https://en.wikivoyage.beta.wmflabs.org/w/load.php?debug=false&lang=en&modul…i%7Cmediawiki.legacy.wikibits&only=scripts&skin=vector&version=0r0nkm9:1:1), <anonymous>:577:586)
    at fire (https://en.wikivoyage.beta.wmflabs.org/w/load.php?debug=false&lang=en&modul…Cmediawiki.legacy.wikibits&only=scripts&skin=vector&version=0r0nkm9:45:122)
    at Object.fireWith [as resolveWith] (https://en.wikivoyage.beta.wmflabs.org/w/load.php?debug=false&lang=en&modul…Cmediawiki.legacy.wikibits&only=scripts&skin=vector&version=0r0nkm9:46:431)
    at Object.deferred.(anonymous function) (https://en.wikivoyage.beta.wmflabs.org/w/load.php?debug=false&lang=en&modul…Cmediawiki.legacy.wikibits&only=scripts&skin=vector&version=0r0nkm9:47:790)
    at fire (https://en.wikivoyage.beta.wmflabs.org/w/load.php?debug=false&lang=en&modul…Cmediawiki.legacy.wikibits&only=scripts&skin=vector&version=0r0nkm9:45:122)
    at Object.fireWith [as resolveWith] (https://en.wikivoyage.beta.wmflabs.org/w/load.php?debug=false&lang=en&modul…Cmediawiki.legacy.wikibits&only=scripts&skin=vector&version=0r0nkm9:46:431)
    at Object.deferred.(anonymous function) (https://en.wikivoyage.beta.wmflabs.org/w/load.php?debug=false&lang=en&modul…Cmediawiki.legacy.wikibits&only=scripts&skin=vector&version=0r0nkm9:47:790)
    at fire (https://en.wikivoyage.beta.wmflabs.org/w/load.php?debug=false&lang=en&modul…Cmediawiki.legacy.wikibits&only=scripts&skin=vector&version=0r0nkm9:45:122)
    at Object.fireWith [as resolveWith] (https://en.wikivoyage.beta.wmflabs.org/w/load.php?debug=false&lang=en&modul…Cmediawiki.legacy.wikibits&only=scripts&skin=vector&version=0r0nkm9:46:431)

The Save dialog won't go away, but if I check the history in different tab the edit is there. This is Chrome in Win10.

Details

ProjectBranchLines +/-Subject
mediawiki/extensions/VisualEditormaster+6 -6mw.DesktopArticleTarget: Use require() for mw.page.watch
Customize query in gerrit

Related Objects

Event Timeline

Elitre created this task.May 24 2017, 7:32 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMay 24 2017, 7:32 PM
Elitre mentioned this in T126361: When editing via VisualEditor Wrong style of Table of Contents displays when saving a page at Wikivoyage.May 24 2017, 7:33 PM
Elitre mentioned this in T166228: [Regression wmf.2] "Uncaught TypeError: Cannot read property 'getDocument' of null" appears after adding any citation.May 24 2017, 7:46 PM
Elitre updated the task description. (Show Details)May 24 2017, 7:50 PM
Elitre updated the task description. (Show Details)
Elitre updated the task description. (Show Details)
gerritbot added a subscriber: gerritbot.May 24 2017, 9:16 PM

Change 355271 had a related patch set uploaded (by Krinkle; owner: Krinkle):
[mediawiki/extensions/VisualEditor@master] mw.DesktopArticleTarget: Use require() for mw.page.watch

https://gerrit.wikimedia.org/r/355271

gerritbot added a project: Patch-For-Review.May 24 2017, 9:16 PM
Krinkle claimed this task.May 24 2017, 9:19 PM
Krinkle added a project: VisualEditor-MediaWiki.
gerritbot added a comment.May 25 2017, 7:49 AM

Change 355271 merged by jenkins-bot:
[mediawiki/extensions/VisualEditor@master] mw.DesktopArticleTarget: Use require() for mw.page.watch

https://gerrit.wikimedia.org/r/355271

ReleaseTaggerBot added a project: MW-1.30-release-notes (WMF-deploy-2017-05-30_(1.30.0-wmf.3)).May 25 2017, 8:00 AM
Jdforrester-WMF closed this task as Resolved.May 25 2017, 9:14 AM
Jdforrester-WMF set the point value for this task to 1.
Jdforrester-WMF moved this task from To Triage to TR0: Interrupt on the VisualEditor board.
Jdforrester-WMF added a subscriber: Jdforrester-WMF.

https://en.wikivoyage.beta.wmflabs.org/w/index.php?title=Tokushima&diff=88&oldid=87 – now fixed.

Restricted Application added a project: User-Ryasmeen. · View Herald TranscriptMay 25 2017, 9:14 AM
Jdforrester-WMF renamed this task from VEditing fails at test wikivoyage wiki (Cannot read property 'hasOwnProperty' of undefined) to [Regression pre-wmf.3] VEditing fails at test wikivoyage wiki (Cannot read property 'hasOwnProperty' of undefined).May 25 2017, 9:15 AM
Jdforrester-WMF triaged this task as High priority.
Jdforrester-WMF removed a project: Patch-For-Review.
Ryasmeen added a project: Verified.May 25 2017, 2:06 PM
Ryasmeen edited projects, added MW-1.30-release-notes (WMF-deploy-2017-06-06_(1.30.0-wmf.4)); removed MW-1.30-release-notes (WMF-deploy-2017-05-30_(1.30.0-wmf.3)).Jun 5 2017, 5:27 PM
Content licensed under Creative Commons Attribution-ShareAlike 3.0 (CC-BY-SA) unless otherwise noted; code licensed under GNU General Public License (GPL) or other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL