Page MenuHomePhabricator

[Regression pre-wmf.3] VEditing fails at test wikivoyage wiki (Cannot read property 'hasOwnProperty' of undefined)
Closed, ResolvedPublic1 Story Points

Description

When I try and save a VEdit (while logged out), the console screams at me:

VM93:1325 Uncaught TypeError: Cannot read property 'hasOwnProperty' of undefined
    at VeInitMwDesktopArticleTarget.ve.init.mw.DesktopArticleTarget.saveComplete (eval at <anonymous> (https://en.wikivoyage.beta.wmflabs.org/w/load.php?debug=false&lang=en&modul…i%7Cmediawiki.legacy.wikibits&only=scripts&skin=vector&version=0r0nkm9:1:1), <anonymous>:1325:818)
    at VeInitMwDesktopArticleTarget.ve.init.mw.ArticleTarget.saveSuccess (eval at <anonymous> (https://en.wikivoyage.beta.wmflabs.org/w/load.php?debug=false&lang=en&modul…i%7Cmediawiki.legacy.wikibits&only=scripts&skin=vector&version=0r0nkm9:1:1), <anonymous>:577:586)
    at fire (https://en.wikivoyage.beta.wmflabs.org/w/load.php?debug=false&lang=en&modul…Cmediawiki.legacy.wikibits&only=scripts&skin=vector&version=0r0nkm9:45:122)
    at Object.fireWith [as resolveWith] (https://en.wikivoyage.beta.wmflabs.org/w/load.php?debug=false&lang=en&modul…Cmediawiki.legacy.wikibits&only=scripts&skin=vector&version=0r0nkm9:46:431)
    at Object.deferred.(anonymous function) (https://en.wikivoyage.beta.wmflabs.org/w/load.php?debug=false&lang=en&modul…Cmediawiki.legacy.wikibits&only=scripts&skin=vector&version=0r0nkm9:47:790)
    at fire (https://en.wikivoyage.beta.wmflabs.org/w/load.php?debug=false&lang=en&modul…Cmediawiki.legacy.wikibits&only=scripts&skin=vector&version=0r0nkm9:45:122)
    at Object.fireWith [as resolveWith] (https://en.wikivoyage.beta.wmflabs.org/w/load.php?debug=false&lang=en&modul…Cmediawiki.legacy.wikibits&only=scripts&skin=vector&version=0r0nkm9:46:431)
    at Object.deferred.(anonymous function) (https://en.wikivoyage.beta.wmflabs.org/w/load.php?debug=false&lang=en&modul…Cmediawiki.legacy.wikibits&only=scripts&skin=vector&version=0r0nkm9:47:790)
    at fire (https://en.wikivoyage.beta.wmflabs.org/w/load.php?debug=false&lang=en&modul…Cmediawiki.legacy.wikibits&only=scripts&skin=vector&version=0r0nkm9:45:122)
    at Object.fireWith [as resolveWith] (https://en.wikivoyage.beta.wmflabs.org/w/load.php?debug=false&lang=en&modul…Cmediawiki.legacy.wikibits&only=scripts&skin=vector&version=0r0nkm9:46:431)

The Save dialog won't go away, but if I check the history in different tab the edit is there. This is Chrome in Win10.

Event Timeline

Elitre created this task.May 24 2017, 7:32 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMay 24 2017, 7:32 PM
Elitre updated the task description. (Show Details)May 24 2017, 7:50 PM
Elitre updated the task description. (Show Details)
Elitre updated the task description. (Show Details)

Change 355271 had a related patch set uploaded (by Krinkle; owner: Krinkle):
[mediawiki/extensions/VisualEditor@master] mw.DesktopArticleTarget: Use require() for mw.page.watch

https://gerrit.wikimedia.org/r/355271

Krinkle claimed this task.May 24 2017, 9:19 PM

Change 355271 merged by jenkins-bot:
[mediawiki/extensions/VisualEditor@master] mw.DesktopArticleTarget: Use require() for mw.page.watch

https://gerrit.wikimedia.org/r/355271

Restricted Application added a project: User-Ryasmeen. · View Herald TranscriptMay 25 2017, 9:14 AM
Jdforrester-WMF renamed this task from VEditing fails at test wikivoyage wiki (Cannot read property 'hasOwnProperty' of undefined) to [Regression pre-wmf.3] VEditing fails at test wikivoyage wiki (Cannot read property 'hasOwnProperty' of undefined).May 25 2017, 9:15 AM
Jdforrester-WMF triaged this task as High priority.
Jdforrester-WMF removed a project: Patch-For-Review.