Page MenuHomePhabricator

spam from phabricator in labs
Closed, ResolvedPublic

Description

The text below is what i originally sent to the ops mailing list, but i am pasting into a ticket here was well so that @Paladox and @Zppix can read and follow-up on it.


We received LOTS of "mail delivery failed" mails originating from phabricator.phabricator.eqiad.wmflabs starting
today, starting about 7.5 hours ago. ( ~ 5 PM UTC)

Google moved all of them into Spam but i noticed when emptying spam folder.

We have puppetized in /etc/aliases

root root@wikimedia.org

and then when it tries to mail root@wikimedia.org, sender verification fails:: 550-Verification failed for <root@phabricator.phabricator.eqiad.wmflabs>"

It's from a root cronjob and the culprit is " /usr/local/bin/exim-to-gmetric"/

The reason for exim-to-gmetric failing is:

/usr/sbin/exim: /usr/lib/x86_64-linux-gnu/libmysqlclient.so.18: no version information available (required by /usr/sbin/exim)

and this should be from:

10:12 < paladox> !log phabricator upgrading mariadb to 10.2

because: /usr/lib/x86_64-linux-gnu/libmysqlclient.so.18: symbolic link to libmariadb.so.3

The cron comes from class exim4::ganglia , so something that is deprecated.

What i am doing for now is comment out the include of exim4::ganglia in the phabricator role.

(It gets included in other places too, let's see if we shouldn't remove all of that right away?)

Event Timeline

^ This is why i disabled puppet on the "phabricator" instance last night.

@Dzahn yep thanks for disabling puppet. I've removed the package and replaced it with the lighter one without mysql and then re-enabled puppet now.

Update: Re disabled it after finding the package got re installed (the heavy one)

Change 355640 had a related patch set uploaded (by Dzahn; owner: Dzahn):
[operations/puppet@production] phabricator: avoid root@wm.org mail alias in labs

https://gerrit.wikimedia.org/r/355640

Change 355640 abandoned by Dzahn:
phabricator: avoid root@wm.org mail alias in labs

https://gerrit.wikimedia.org/r/355640

Paladox triaged this task as High priority.May 25 2017, 9:04 PM

Setting as hi as i do not want to spam ops.

Change 355717 had a related patch set uploaded (by Paladox; owner: Paladox):
[operations/puppet@production] Phabricator: Install the lighter version of exim4 on labs only

https://gerrit.wikimedia.org/r/355717

Change 355640 restored by Dzahn:
phabricator: avoid root@wm.org mail alias in labs

https://gerrit.wikimedia.org/r/355640

It's (also) an issue of the Phabricator Puppet module in general. The goal is that it can be used in Labs to test changes before they hit prod. Currently it can't be without having side-effects like this.

Change 355741 had a related patch set uploaded (by Dzahn; owner: Dzahn):
[operations/puppet@production] stop using exim4::ganglia

https://gerrit.wikimedia.org/r/355741

Change 355717 abandoned by Faidon Liambotis:
Phabricator: Install the lighter version of exim4 on labs only

Reason:
Misguided

https://gerrit.wikimedia.org/r/355717

Change 355741 abandoned by Dzahn:
stop using exim4::ganglia

https://gerrit.wikimedia.org/r/355741

Change 355640 abandoned by Dzahn:
phabricator: avoid root@wm.org mail alias in labs

https://gerrit.wikimedia.org/r/355640

exim-ganglia stats can/should be removed from everything, which will also close this. also, i haven't received any of this in a long time.

@Paladox remember if manual changes were made to avoid this?

Dzahn lowered the priority of this task from High to Medium.

@Dzahn yep, I’ve applied them manually on the puppet master and there somewhere in the git log.

Dzahn changed the task status from Open to Stalled.Nov 2 2017, 7:02 AM

blocked on T179302

Dzahn lowered the priority of this task from Medium to Low.Nov 2 2017, 7:03 AM

Yes, it can. exim4::ganglia has been deleted as part of T177225 so Puppet will definitely not re-add that anywhere.

And specifically from the Phabricator role it was removed in https://gerrit.wikimedia.org/r/#/c/382916/

Worst case there would be remnant cron but looks we got them all since there was no more spam.

It's from a root cronjob and the culprit is " /usr/local/bin/exim-to-gmetric"/