| Mhurd | |
| May 26 2017, 1:14 AM |
| F8183509: Screen Shot 2017-05-25 at 5.26.02 PM.png | |
| May 26 2017, 1:14 AM |
This survey T165546 introduced the tags seen above.
I noticed it and @bearND did a hot fix here: https://gerrit.wikimedia.org/r/#/c/355734/
We could:
Note: it was decided we would add test for now.
| Project | Branch | Lines +/- | Subject | |
|---|---|---|---|---|
| mediawiki/services/mobileapps | master | +30 -1 | Add test for HTML in certain iOS announcement fields |
Change 355865 had a related patch set uploaded (by Mhurd; owner: Mhurd):
[mediawiki/services/mobileapps@master] Add test for HTML in certain iOS announcement fields
I added an upstream test for the feed announcement endpoint.
You can see it in the gerrit commit link in the comment above this one. @bearND is reviewing.
Could the iOS app be changed to handle HTML instead of plain text? The Android app seems to handle it fine.
I need to address the feedback on the gerrit ticket - will try to get to this tomorrow.
Hmm I updated the patch to address Michael's feedback, but Jenkins didn't like it - wasn't clear from the console output why... will check Monday.
Could the iOS app be changed to handle HTML instead of plain text? The Android app seems to handle it fine.
iOS's UITextFields and UILabels don't handle HTML as efficiently as the Android equivalents do :(
We can add code to translate between HTML and the native attributed strings, but it would be easiest to test for unsupported HTML in the mean time.
@bearND I'm keeping my fingers crossed that they announce some improvements for this at WWDC this week :)
Change 355865 merged by jenkins-bot:
[mediawiki/services/mobileapps@master] Add test for HTML in certain iOS announcement fields
@JMinor This got merged upstream today - moved directly to PM signoff since not really QA-testable.