Page MenuHomePhabricator

jquery.makeCollapsible: Default toggle no longer looks clickable (should use <a>)
Closed, ResolvedPublic

Description

Due to change Ic8627c4c185e8e4175e6fef1c8e1c2190e54edaa [show]/[hide] links of mw-collapsible doesn't use <a>.

While <a> may not be required from functional POV, it has look & feel of "clickable". The change doesn't preserve it, and [show]/[hide] links appear as black (though it does shown with cursor: pointer;).

Event Timeline

eranroz created this task.May 26 2017, 5:06 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMay 26 2017, 5:06 AM
matmarex reopened this task as Open.May 26 2017, 4:44 PM
matmarex added a project: Regression.

This looks to have been accidentally closed? It doesn't seem resolved, and definitely not by f0e12ae951ef. See e.g. https://test.wikipedia.org/wiki/Test_suite_for_mw-collapsible for examples.

The new toggles indeed do not look clickable, they look like just the page text. They should be using links, buttons, or perhaps some custom styling, to distinguish them.

matmarex updated the task description. (Show Details)May 26 2017, 4:44 PM
Krinkle renamed this task from mw-collapsible show/hide doesn't look clickable to jquery.makeCollapsible: Default toggle no longer looks clickable (should use <a>).May 26 2017, 4:57 PM
Krinkle edited projects, added MediaWiki-Interface; removed MediaWiki-General.
Krinkle triaged this task as High priority.May 26 2017, 5:21 PM

Change 355874 had a related patch set uploaded (by Mollgear; owner: Mollgear):
[mediawiki/core@master] Making the default toggle look clickable again

https://gerrit.wikimedia.org/r/355874

I'm sorry. I misunderstood the title and mixed it up with the commit mentioned above. I submitted a new patch.

TheDJ added a subscriber: TheDJ.May 29 2017, 3:26 PM
matmarex closed this task as Resolved.May 29 2017, 3:31 PM
matmarex removed a project: Patch-For-Review.

Thanks! I merged the change. It'll be deployed to Wikimedia wikis this week, 30 May – 1 June, per the usual schedule.

Change 355874 merged by jenkins-bot:
[mediawiki/core@master] Making the default toggle look clickable again

https://gerrit.wikimedia.org/r/355874

Jdforrester-WMF added a subscriber: Jdforrester-WMF.

Mass-moving all items tagged for MediaWiki 1.30.0-wmf.3, as that was never released; instead, we're using -wmf.4.